jdyer1 merged PR #2374:
URL: https://github.com/apache/solr/pull/2374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
jdyer1 commented on PR #2374:
URL: https://github.com/apache/solr/pull/2374#issuecomment-2033116140
Unless there are objections I would like to merge this one soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jdyer1 commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1548589588
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##
@@ -469,6 +531,23 @@ protected String
allProcessorSupportedContentTypesCommaDelimited(
jdyer1 commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1548587323
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientTestBase.java:
##
@@ -532,4 +538,67 @@ protected void
testUseOptionalCredentialsWithNull(HttpSolrCli
dsmiley commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1546911504
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##
@@ -469,6 +531,23 @@ protected String
allProcessorSupportedContentTypesCommaDelimited(
jdyer1 commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1546681105
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##
@@ -469,6 +531,23 @@ protected String
allProcessorSupportedContentTypesCommaDelimited(
dsmiley commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1545278812
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/DebugServlet.java:
##
@@ -136,6 +137,16 @@ private void recordRequest(HttpServletRequest req,
HttpServletResponse
jdyer1 opened a new pull request, #2374:
URL: https://github.com/apache/solr/pull/2374
This PR adds method `asyncRequest` to abstract supertype
`HttpSolrClientBase` and implements it on `HttpJdkSolrClient`. Also adds unit
tests for normal, exceptional and cancelled asynchronous requests,
