Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-08-20 Thread via GitHub
uschindler commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2298151122 I just merged this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-08-20 Thread via GitHub
uschindler merged PR #2387: URL: https://github.com/apache/solr/pull/2387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-08-19 Thread via GitHub
github-actions[bot] commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2297718580 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please t

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-06-04 Thread via GitHub
github-actions[bot] commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2148598862 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
uschindler commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2034997136 > Will take another look at the javadoc links. What gradle command do I run to build javadocs that should have substituted local javadocs? Do I have to unzip some jdk javadoc file into my

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
janhoy commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2034339316 Will take another look at the javadoc links. What gradle command do I run to build javadocs that should have substituted local javadocs? Do I have to unzip some jdk javadoc file into my git c

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
janhoy commented on code in PR #2387: URL: https://github.com/apache/solr/pull/2387#discussion_r1549333462 ## gradle/documentation/render-javadoc.gradle: ## @@ -370,7 +370,7 @@ class RenderJavadocTask extends DefaultTask { opts << [ '-linkoffline', url, dir ] } -

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
uschindler commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2033910058 P.S.: I missed this in Lucene, there is also a reference to the JDK Javadocs and its package file above. We may also make this dynamic. -- This is an automated message from the Apache G

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
cpoerschke commented on code in PR #2387: URL: https://github.com/apache/solr/pull/2387#discussion_r1549234517 ## gradle/documentation/render-javadoc.gradle: ## @@ -370,7 +370,7 @@ class RenderJavadocTask extends DefaultTask { opts << [ '-linkoffline', url, dir ] }

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
uschindler commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2033894291 The approach you used did not work in Lucene because inputs/outputs and "rootProject" was not known in the task instance. Here it is different, if it works, +1 -- This is an automated

[PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
janhoy opened a new pull request, #2387: URL: https://github.com/apache/solr/pull/2387 Oneliner :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: