bruno-roustant merged PR #2400:
URL: https://github.com/apache/solr/pull/2400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
epugh commented on code in PR #2400:
URL: https://github.com/apache/solr/pull/2400#discussion_r1561301167
##
solr/core/src/java/org/apache/solr/util/IndexOutputOutputStream.java:
##
@@ -20,11 +20,12 @@
import java.io.OutputStream;
import org.apache.lucene.store.IndexOutput;
bruno-roustant commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2050033287
Renamed. It was used only in two internal locations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
epugh commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2050014227
The name "IndexOutputOutputStream", while slightly funny, is fine, with just
a bit of docs to highlight what you said "wrap an IndexOutput to expose it as
an OutputStream" would have helped
dsmiley commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2049990316
Lets rename this in main; separate no-JIRA PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bruno-roustant commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2049987103
I think PropertiesOutputStream could be renamed IndexOutputOutputStream
because it is used to wrap an IndexOutput to expose it as an OutputStream.
I can add some JavaDoc. Do you
epugh commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2049846868
Some JavaDocs on this class would be nice.. I looked at it, and I still
don't quite grok why it is needed for a properties file?
--
This is an automated message from the Apache Git
bruno-roustant opened a new pull request, #2400:
URL: https://github.com/apache/solr/pull/2400
https://issues.apache.org/jira/browse/SOLR-17232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
