gus-asf merged PR #2595:
URL: https://github.com/apache/solr/pull/2595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
gus-asf commented on PR #2595:
URL: https://github.com/apache/solr/pull/2595#issuecomment-2256114568
Review feedback addressed, Thinking of committing to main tomorrow if no
further feedback. Backport to 9x intended a few days after that assuming that
goes well...
--
This is an automated
gus-asf commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1693385066
##
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##
@@ -313,6 +340,37 @@ public MDCAwareThreadPoolExecutor(
RejectedExecutionHandler handler)
dsmiley commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1693381153
##
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##
@@ -313,6 +340,37 @@ public MDCAwareThreadPoolExecutor(
RejectedExecutionHandler handler)
dsmiley commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1693382984
##
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##
@@ -313,6 +340,37 @@ public MDCAwareThreadPoolExecutor(
RejectedExecutionHandler handler)
gus-asf commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1693382945
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1921,9 +1921,7 @@ public ScoreMode scoreMode() {
final TopDocs topDocs;
final Sco
dsmiley commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1693362912
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1921,9 +1921,7 @@ public ScoreMode scoreMode() {
final TopDocs topDocs;
final Sco
cpoerschke commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1692996096
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1921,9 +1921,7 @@ public ScoreMode scoreMode() {
final TopDocs topDocs;
final
gus-asf commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1692984958
##
solr/core/src/test/org/apache/solr/search/TestCpuAllowedLimit.java:
##
@@ -61,7 +65,12 @@ private static Path createConfigSet() throws Exception {
}
@BeforeClas
cpoerschke commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1692900328
##
solr/core/src/test/org/apache/solr/search/TestCpuAllowedLimit.java:
##
@@ -61,7 +65,12 @@ private static Path createConfigSet() throws Exception {
}
@BeforeC
gus-asf opened a new pull request, #2595:
URL: https://github.com/apache/solr/pull/2595
https://issues.apache.org/jira/browse/SOLR-17298
This introduces a version of ThreadCpuTimer class that does not need to
depend on the request context or be instantiated to track timing. This appro
11 matches
Mail list logo
