epugh merged PR #2557:
URL: https://github.com/apache/solr/pull/2557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
bogdanstoik commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2232682988
> by the way @bogdanstoik how did you find this bug? Did you have a scripte
using the `-params`?
Yes. I was trying to load a tab-separated csv and it kept complaining about
not fi
epugh commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2232658578
by the way @bogdanstoik how did you find this bug? Did you have a scripte
using the `-params`?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
epugh commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2232513816
One more thought which is that sometimes I find it easier to write a bats
test instead of Java... post.bats is used to test out the cli against a live
solr...
--
This is an automated mess
bogdanstoik commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231681249
> > thanks for the addition of the tests.. I will inline some comments
one thing, did you run `gradlew tidy`? that does some code formatting.
>
> I did not 🤦♂️. I had a blast
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679963315
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
assertEquals("*:*
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679962349
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
assertEquals("*:*
bogdanstoik commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231661162
> Looks like some great progress. A couple of questions! When I add it to
`CHANGES.txt`, how would you like to be credited?
Bostoi
Thank you
--
This is an automated messa
bogdanstoik commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231646527
> thanks for the addition of the tests.. I will inline some comments one
thing, did you run `gradlew tidy`? that does some code formatting.
I did not 🤦♂️.
I had a blast wri
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679930353
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
assertEquals("*:*
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679929573
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
assertEquals("*:*
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679926338
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
assertEquals("*:*
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679924535
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -311,6 +312,8 @@ public void runImpl(CommandLine cli) throws Exception {
args = cli.getArgs();
epugh commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679567571
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -311,6 +312,8 @@ public void runImpl(CommandLine cli) throws Exception {
args = cli.getArgs();
+p
epugh commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231124432
thanks for the addition of the tests.. I will inline some comments
one thing, did you run `gradlew tidy`? that does some code formatting.
--
This is an automated message from the Apa
bogdanstoik opened a new pull request, #2557:
URL: https://github.com/apache/solr/pull/2557
https://issues.apache.org/jira/browse/SOLR-17367
# Description
Adding support for -params option in org.apache.solr.cli.PostTool
# Solution
I modified the post
bogdanstoik closed pull request #2556: SOLR-17367: org.apache.solr.cli.PostTool
is ignoring -params option
URL: https://github.com/apache/solr/pull/2556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bogdanstoik opened a new pull request, #2556:
URL: https://github.com/apache/solr/pull/2556
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
18 matches
Mail list logo
