Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

dsmiley merged PR #2619: URL: https://github.com/apache/solr/pull/2619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

psalagnac commented on PR #2619: URL: https://github.com/apache/solr/pull/2619#issuecomment-2275386537 I also updated Javadoc of the other variant (unbounded pool) to reduce confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

psalagnac commented on PR #2619: URL: https://github.com/apache/solr/pull/2619#issuecomment-2275296108 > Are we good with the CHANGES.txt and other changes? (Pierre or anyone else?) I would also mention shard Split, as it was also impacted. A single thread per node was processing all

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

dsmiley commented on PR #2619: URL: https://github.com/apache/solr/pull/2619#issuecomment-2274878399 Are we good with the CHANGES.txt and other changes? (Pierre or anyone else?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

dsmiley commented on PR #2619: URL: https://github.com/apache/solr/pull/2619#issuecomment-2273984102 After reading ThreadPoolExecutor's docs a bit more, I was surprised to see that a new thread will be created for a new task when the thread count is less than the core size _even if there ar

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

dsmiley commented on code in PR #2619: URL: https://github.com/apache/solr/pull/2619#discussion_r1705975931 ## solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java: ## @@ -243,15 +243,27 @@ public static ExecutorService newMDCAwareCachedThreadPool(ThreadFactory thr

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

madrob commented on code in PR #2619: URL: https://github.com/apache/solr/pull/2619#discussion_r1705773515 ## solr/solrj/src/test/org/apache/solr/common/util/ExecutorUtilTest.java: ## @@ -108,6 +111,48 @@ public void testExecutorUtilAwaitsTerminationWhenTaskRespectsInterupt() t

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

psalagnac commented on code in PR #2619: URL: https://github.com/apache/solr/pull/2619#discussion_r1705765822 ## solr/solrj/src/test/org/apache/solr/common/util/ExecutorUtilTest.java: ## @@ -108,6 +111,48 @@ public void testExecutorUtilAwaitsTerminationWhenTaskRespectsInterupt(

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

psalagnac commented on code in PR #2619: URL: https://github.com/apache/solr/pull/2619#discussion_r1705724005 ## solr/solrj/src/test/org/apache/solr/common/util/ExecutorUtilTest.java: ## @@ -108,6 +111,48 @@ public void testExecutorUtilAwaitsTerminationWhenTaskRespectsInterupt(

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

madrob commented on code in PR #2619: URL: https://github.com/apache/solr/pull/2619#discussion_r1705719172 ## solr/solrj/src/test/org/apache/solr/common/util/ExecutorUtilTest.java: ## @@ -108,6 +111,48 @@ public void testExecutorUtilAwaitsTerminationWhenTaskRespectsInterupt() t

[PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

psalagnac opened a new pull request, #2619: URL: https://github.com/apache/solr/pull/2619 https://issues.apache.org/jira/browse/SOLR-17391 # Description Cached thread pools never start more than one thread. Consequently, all the async tasks are executed sequentially