Re: [PR] Various asf.yaml updates [solr]

2024-01-12 Thread via GitHub
janhoy merged PR #2185: URL: https://github.com/apache/solr/pull/2185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Various asf.yaml updates [solr]

2024-01-12 Thread via GitHub
janhoy commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1450266926 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} Review Comment: Also, `.asf.yaml` does not supp

Re: [PR] Various asf.yaml updates [solr]

2024-01-12 Thread via GitHub
janhoy commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1450265891 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} Review Comment: I added lines for all current `

Re: [PR] Various asf.yaml updates [solr]

2024-01-11 Thread via GitHub
janhoy commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1449570376 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} Review Comment: I cannot see it documented. But

Re: [PR] Various asf.yaml updates [solr]

2024-01-11 Thread via GitHub
dsmiley commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1448883424 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} Review Comment: Is there a way to add `branch_

Re: [PR] Various asf.yaml updates [solr]

2024-01-09 Thread via GitHub
janhoy commented on PR #2185: URL: https://github.com/apache/solr/pull/2185#issuecomment-1883959207 Also, I consider `required_conversation_resolution`, which will require all conversations to be resolved before merging is possible. I have seen too quick merges of looong PRs where the autho

Re: [PR] Various asf.yaml updates [solr]

2024-01-09 Thread via GitHub
janhoy commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1446716007 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} + + protected_tags: +- "releases/*" + + autol

Re: [PR] Various asf.yaml updates [solr]

2024-01-09 Thread via GitHub
cpoerschke commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1446335788 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} + + protected_tags: +- "releases/*" + + a

[PR] Various asf.yaml updates [solr]

2024-01-09 Thread via GitHub
janhoy opened a new pull request, #2185: URL: https://github.com/apache/solr/pull/2185 I browsed the [asf.yaml docs](https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=git+-+.asf.yaml+features), and found several new capabilities related to GitHub that I believe