Bruno Roustant created SOLR-16255: ------------------------------------- Summary: Introduce DirectUpdateHandler2#shouldCommit Key: SOLR-16255 URL: https://issues.apache.org/jira/browse/SOLR-16255 Project: Solr Issue Type: Improvement Security Level: Public (Default Security Level. Issues are Public) Reporter: Bruno Roustant
Currently DirectUpdateHandler2 checks IndexWriter.hasUncommittedChanges() before effectively calling IndexWriter.commit(). It is also possible for the user to provide custom commit metadata in the CommitUpdateCommand.commitData field. The proposed change is to move the check to IndexWriter.hasUncommittedChanges() in a new protected method DirectUpdateHandler2.shouldCommit(), which would also check (logical or) if the CommitUpdateCommand contains user defined commit metadata. It becomes possible to commit without change, but with user defined commit metadata. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org