HoustonPutman merged PR #2436:
URL: https://github.com/apache/solr/pull/2436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1587879478
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java:
##
@@ -56,6 +58,10 @@ public abstract class
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586911809
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java:
##
@@ -56,6 +58,10 @@ public abstract class
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586911809
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java:
##
@@ -56,6 +58,10 @@ public abstract class
HoustonPutman commented on PR #2436:
URL: https://github.com/apache/solr/pull/2436#issuecomment-2089162157
Thanks for the info on those. I've standardized both the reseting of
sysProps as well as where the option is set from.
--
This is an automated message from the Apache Git Service.
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586786180
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -140,28 +143,29 @@ public static void shutdownCluster() throws Exception {
HoustonPutman commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586713299
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -140,29 +138,18 @@ public static void shutdownCluster() throws Exception {
dsmiley commented on code in PR #2436:
URL: https://github.com/apache/solr/pull/2436#discussion_r1586652988
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -83,7 +83,7 @@ public class SolrCloudTestCase extends SolrTestCaseJ4 {
private
HoustonPutman opened a new pull request, #2436:
URL: https://github.com/apache/solr/pull/2436
https://issues.apache.org/jira/browse/SOLR-17265
This fixes the test errors introduced by
https://github.com/apache/solr/pull/2230
I'm not really certain what the previous logic was
