[ 
https://issues.apache.org/jira/browse/SPARK-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025895#comment-14025895
 ] 

Erik Erlandson edited comment on SPARK-1493 at 6/9/14 11:13 PM:
----------------------------------------------------------------

RAT itself appears to preclude exclusion using a "/path/to/file.ext" regex 
because it traverses the directory tree and applies its exclusion filter only 
to individual file names.  The filter never sees an entire path 
"path/to/file.ext", only "path", "to", and "file.ext"

https://github.com/apache/rat/blob/incubator-site-import/rat/rat-core/src/main/java/org/apache/rat/DirectoryWalker.java#L127

Either RAT needs a new filtering feature that can see an entire path, or the 
report it generates has to be filtered post-hoc.

Filed an RFE against RAT:  RAT-161


was (Author: eje):
RAT itself appears to preclude exclusion using a "/path/to/file.ext" regex 
because it traverses the directory tree and applies its exclusion filter only 
to individual file names.  The filter never sees an entire path 
"path/to/file.ext", only "path", "to", and "file.ext"

https://github.com/apache/rat/blob/incubator-site-import/rat/rat-core/src/main/java/org/apache/rat/DirectoryWalker.java#L127

Either RAT needs a new filtering feature that can see an entire path, or the 
report it generates has to be filtered post-hoc.


> Apache RAT excludes don't work with file path (instead of file name)
> --------------------------------------------------------------------
>
>                 Key: SPARK-1493
>                 URL: https://issues.apache.org/jira/browse/SPARK-1493
>             Project: Spark
>          Issue Type: Bug
>          Components: Project Infra
>            Reporter: Patrick Wendell
>              Labels: starter
>             Fix For: 1.1.0
>
>
> Right now the way we do RAT checks, it doesn't work if you try to exclude:
> /path/to/file.ext
> you have to just exclude
> file.ext



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to