[jira] [Commented] (SPARK-15618) Use SparkSession.builder.sparkContext(...) in tests where possible

2016-05-27 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-15618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304891#comment-15304891 ] Apache Spark commented on SPARK-15618: -- User 'dongjoon-hyun' has created a pull request for this

[jira] [Commented] (SPARK-15618) Use SparkSession.builder.sparkContext(...) in tests where possible

2016-05-27 Thread Dongjoon Hyun (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-15618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304509#comment-15304509 ] Dongjoon Hyun commented on SPARK-15618: --- Thank you! Right. That's better. > Use

[jira] [Commented] (SPARK-15618) Use SparkSession.builder.sparkContext(...) in tests where possible

2016-05-27 Thread Andrew Or (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-15618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304506#comment-15304506 ] Andrew Or commented on SPARK-15618: --- it needs to be internal. At least it should be private[spark] >

[jira] [Commented] (SPARK-15618) Use SparkSession.builder.sparkContext(...) in tests where possible

2016-05-27 Thread Dongjoon Hyun (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-15618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304498#comment-15304498 ] Dongjoon Hyun commented on SPARK-15618: --- Is it okay if I remove `private[sql]` from that function?

[jira] [Commented] (SPARK-15618) Use SparkSession.builder.sparkContext(...) in tests where possible

2016-05-27 Thread Dongjoon Hyun (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-15618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304486#comment-15304486 ] Dongjoon Hyun commented on SPARK-15618: --- Thank you for creating JIRA for this. I'll start now. :)