[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2017-01-12 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820681#comment-15820681 ] Apache Spark commented on SPARK-18209: -- User 'jiangxb1987' has created a pull request for this

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-12-09 Thread Wenchen Fan (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737368#comment-15737368 ] Wenchen Fan commented on SPARK-18209: - Hmm, `AnalysisContext` maybe an overkill, can we just

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-12-06 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726694#comment-15726694 ] Reynold Xin commented on SPARK-18209: - I took a look at the change quickly and here are my high level

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-12-06 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725038#comment-15725038 ] Apache Spark commented on SPARK-18209: -- User 'jiangxb1987' has created a pull request for this

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-12-02 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717188#comment-15717188 ] Xiao Li commented on SPARK-18209: - Yeah, the view definition will be much shorter in this case. > More

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-12-02 Thread Vish Persaud (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717160#comment-15717160 ] Vish Persaud commented on SPARK-18209: -- Might this change also resolve the following issue: bq.

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-23 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691364#comment-15691364 ] Xiao Li commented on SPARK-18209: - [~jiangxb1987] Have you considered the impact on the existing uncache

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-23 Thread Jiang Xingbo (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690451#comment-15690451 ] Jiang Xingbo commented on SPARK-18209: -- I changed the share settings of the doc, I hope everyone can

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-23 Thread Nattavut Sutyanyong (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690426#comment-15690426 ] Nattavut Sutyanyong commented on SPARK-18209: - [~jiangxb1987] Could you please grant me a

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-23 Thread Jiang Xingbo (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689577#comment-15689577 ] Jiang Xingbo commented on SPARK-18209: -- Hi all, I have recently prepared a design document for Spark

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-09 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651798#comment-15651798 ] Reynold Xin commented on SPARK-18209: - Here is a ticket

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-09 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651772#comment-15651772 ] Xiao Li commented on SPARK-18209: - We are also facing another challenge: `cyclic view defintion

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-03 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631952#comment-15631952 ] Liang-Chi Hsieh commented on SPARK-18209: - Ya. I see that. > More robust view canonicalization

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-03 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631946#comment-15631946 ] Reynold Xin commented on SPARK-18209: - No they shouldn't be allowed. I added that to SPARK-18217. >

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631292#comment-15631292 ] Liang-Chi Hsieh commented on SPARK-18209: - I think the disallowed one is to use CTEs in a

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630023#comment-15630023 ] Reynold Xin commented on SPARK-18209: - Yea it's definitely much harder to make logical plan stable

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Nattavut Sutyanyong (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629368#comment-15629368 ] Nattavut Sutyanyong commented on SPARK-18209: - I could think of another alternative but IMHO,

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Nattavut Sutyanyong (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629339#comment-15629339 ] Nattavut Sutyanyong commented on SPARK-18209: - Agreed. > More robust view canonicalization

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Herman van Hovell (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629296#comment-15629296 ] Herman van Hovell commented on SPARK-18209: --- It might be even easier to store the current

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Nattavut Sutyanyong (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629282#comment-15629282 ] Nattavut Sutyanyong commented on SPARK-18209: - Sorry if this is a naive question. [~lian

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Nattavut Sutyanyong (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629273#comment-15629273 ] Nattavut Sutyanyong commented on SPARK-18209: - The challenge in Spark is the interweaving of

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628128#comment-15628128 ] Liang-Chi Hsieh commented on SPARK-18209: - So I think permanent views shouldn't be allowed to use

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628117#comment-15628117 ] Reynold Xin commented on SPARK-18209: - No. > More robust view canonicalization without full SQL

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628099#comment-15628099 ] Liang-Chi Hsieh commented on SPARK-18209: - Can we guarantee temp UDFs still valid in next run? >

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628084#comment-15628084 ] Reynold Xin commented on SPARK-18209: - UDFs should be valid -- temp UDFs should not be? > More

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-02 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628070#comment-15628070 ] Liang-Chi Hsieh commented on SPARK-18209: - I just think of not built-in UDFs which are registered

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627715#comment-15627715 ] Xiao Li commented on SPARK-18209: - Ok, will do it. Thanks! > More robust view canonicalization without

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627710#comment-15627710 ] Reynold Xin commented on SPARK-18209: - Actually I'd consider it a "bug" and fix this bug first in

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627702#comment-15627702 ] Xiao Li commented on SPARK-18209: - True. {code} Seq((1, (1, 1))).toDF().createTempView("temp_jt")

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627679#comment-15627679 ] Reynold Xin commented on SPARK-18209: - Yes, both global and local temp views. The issue with temp

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627673#comment-15627673 ] Xiao Li commented on SPARK-18209: - Without SQL expansion, also need to block the global temp view usage

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627664#comment-15627664 ] Reynold Xin commented on SPARK-18209: - Yup - we will have to disallow it, for good reasons actually.

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627662#comment-15627662 ] Xiao Li commented on SPARK-18209: - Yeah, I just posted the example to show it. I mentioned [~vssrinath]

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627628#comment-15627628 ] Reynold Xin commented on SPARK-18209: - That's what [~vssrinath] pointed out isn't that? Good point

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627599#comment-15627599 ] Xiao Li commented on SPARK-18209: - Please hold on until we finalize the design. > More robust view

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627595#comment-15627595 ] Xiao Li commented on SPARK-18209: - If we do not qualify the table/persistent view name when we create a

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627588#comment-15627588 ] Xiao Li commented on SPARK-18209: - {code} sql("CREATE VIEW jtv1 AS SELECT * FROM jt WHERE id > 3")

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Dongjoon Hyun (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627518#comment-15627518 ] Dongjoon Hyun commented on SPARK-18209: --- Thank you. Now, I understand. I have been wondering the

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627502#comment-15627502 ] Reynold Xin commented on SPARK-18209: - The pr is still useful -- the only thing that made it very

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Dongjoon Hyun (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627407#comment-15627407 ] Dongjoon Hyun commented on SPARK-18209: --- BTW, [~rxin]. I didn't notice that the following was the

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Jiang Xingbo (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627367#comment-15627367 ] Jiang Xingbo commented on SPARK-18209: -- I'm working on this, thanks! > More robust view

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Reynold Xin (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627085#comment-15627085 ] Reynold Xin commented on SPARK-18209: - Yes - that is even simpler and wouldn't require us to support

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Srinath (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626971#comment-15626971 ] Srinath commented on SPARK-18209: - Given that the hive metastore lets you store column names and types

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Srinath (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626838#comment-15626838 ] Srinath commented on SPARK-18209: - A practical (positive) consequence of this is query expansion when we

[jira] [Commented] (SPARK-18209) More robust view canonicalization without full SQL expansion

2016-11-01 Thread Cheng Lian (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626823#comment-15626823 ] Cheng Lian commented on SPARK-18209: One problem of the proposed approach is that our SQL parser