[jira] [Commented] (SPARK-2038) Don't shadow "conf" variable in saveAsHadoop functions

2014-06-19 Thread Nan Zhu (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037739#comment-14037739 ] Nan Zhu commented on SPARK-2038: [~pwendell] Yeah, it's a good idea, just submit a new PR:

[jira] [Commented] (SPARK-2038) Don't shadow "conf" variable in saveAsHadoop functions

2014-06-19 Thread Patrick Wendell (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037703#comment-14037703 ] Patrick Wendell commented on SPARK-2038: Hey [~CodingCat] - I realized there is ac

[jira] [Commented] (SPARK-2038) Don't shadow "conf" variable in saveAsHadoop functions

2014-06-17 Thread Patrick Wendell (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034864#comment-14034864 ] Patrick Wendell commented on SPARK-2038: It was my fault for proposing this change

[jira] [Commented] (SPARK-2038) Don't shadow "conf" variable in saveAsHadoop functions

2014-06-17 Thread Nan Zhu (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034739#comment-14034739 ] Nan Zhu commented on SPARK-2038: Ah, I seethat's fine... > Don't shadow "conf" variab

[jira] [Commented] (SPARK-2038) Don't shadow "conf" variable in saveAsHadoop functions

2014-06-17 Thread Patrick Wendell (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034735#comment-14034735 ] Patrick Wendell commented on SPARK-2038: Unfortunately after discussion with Reyno

[jira] [Commented] (SPARK-2038) Don't shadow "conf" variable in saveAsHadoop functions

2014-06-14 Thread Nan Zhu (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031746#comment-14031746 ] Nan Zhu commented on SPARK-2038: PR: https://github.com/apache/spark/pull/1087 > Don't sh