[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-08 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245063#comment-16245063 ] Apache Spark commented on SPARK-22211: -- User 'henryr' has created a pull request for

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-08 Thread Dongjoon Hyun (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245029#comment-16245029 ] Dongjoon Hyun commented on SPARK-22211: --- Hi, All. This breaks `branch-2.2`. - SBT:

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-03 Thread Henry Robinson (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238281#comment-16238281 ] Henry Robinson commented on SPARK-22211: Sounds good, thanks both. > LimitPushDo

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-03 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237825#comment-16237825 ] Xiao Li commented on SPARK-22211: - We should merge it to the master and the previous rele

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-03 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237822#comment-16237822 ] Sean Owen commented on SPARK-22211: --- In the name of correctness, still worth disabling

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-03 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237797#comment-16237797 ] Xiao Li commented on SPARK-22211: - The Join operator should be limit aware. Anyway, we ca

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-03 Thread Henry Robinson (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237778#comment-16237778 ] Henry Robinson commented on SPARK-22211: [~smilegator] - sounds good! What will y

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-02 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237133#comment-16237133 ] Xiao Li commented on SPARK-22211: - Will submit a PR based on my previous PR https://gith

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-11-02 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236861#comment-16236861 ] Apache Spark commented on SPARK-22211: -- User 'henryr' has created a pull request for

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-10-30 Thread Henry Robinson (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225816#comment-16225816 ] Henry Robinson commented on SPARK-22211: Thinking about it a more, I think the op

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-10-27 Thread Henry Robinson (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223073#comment-16223073 ] Henry Robinson commented on SPARK-22211: I think the optimization proposed works

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-10-12 Thread Takeshi Yamamuro (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202863#comment-16202863 ] Takeshi Yamamuro commented on SPARK-22211: -- Aha, I misunderstood. But, I think t

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-10-12 Thread Benyi Wang (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202278#comment-16202278 ] Benyi Wang commented on SPARK-22211: I think my suggestion solution is correct. || C

[jira] [Commented] (SPARK-22211) LimitPushDown optimization for FullOuterJoin generates wrong results

2017-10-05 Thread Takeshi Yamamuro (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194170#comment-16194170 ] Takeshi Yamamuro commented on SPARK-22211: -- Probably, the suggested solution doe