[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-03-01 Thread Yakov Kerzhner (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293027#comment-17293027 ] Yakov Kerzhner commented on SPARK-34448: I will try to do a code review, but will focus on the

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-03-01 Thread Yakov Kerzhner (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293017#comment-17293017 ] Yakov Kerzhner commented on SPARK-34448: I took a look over the weekend.  It seems good, and

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-03-01 Thread Sean R. Owen (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292924#comment-17292924 ] Sean R. Owen commented on SPARK-34448: -- [~ykerzhner] you may be interested in reviewing

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-03-01 Thread Apache Spark (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292778#comment-17292778 ] Apache Spark commented on SPARK-34448: -- User 'zhengruifeng' has created a pull request for this

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-03-01 Thread Apache Spark (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292779#comment-17292779 ] Apache Spark commented on SPARK-34448: -- User 'zhengruifeng' has created a pull request for this

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-26 Thread Yakov Kerzhner (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291757#comment-17291757 ] Yakov Kerzhner commented on SPARK-34448: The faster convergence when using standardization that

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-26 Thread zhengruifeng (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291562#comment-17291562 ] zhengruifeng commented on SPARK-34448: -- I am not sure to: 1, center the vector in existing impl (I

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-26 Thread zhengruifeng (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291559#comment-17291559 ] zhengruifeng commented on SPARK-34448: -- 1, I just make a simple

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-25 Thread zhengruifeng (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291384#comment-17291384 ] zhengruifeng commented on SPARK-34448: -- My test code and log is here > Binary logistic regression

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-25 Thread Apache Spark (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291383#comment-17291383 ] Apache Spark commented on SPARK-34448: -- User 'zhengruifeng' has created a pull request for this

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-25 Thread zhengruifeng (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291378#comment-17291378 ] zhengruifeng commented on SPARK-34448: -- [~srowen] [~weichenxu123]  [~ykerzhner] My findings until

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-24 Thread zhengruifeng (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290642#comment-17290642 ] zhengruifeng commented on SPARK-34448: -- [~srowen] Thanks for pinging me, I am going to look into

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-24 Thread Sean R. Owen (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290158#comment-17290158 ] Sean R. Owen commented on SPARK-34448: -- I crudely ported the test setup to a Scala test, and tried

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-24 Thread Sean R. Owen (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290052#comment-17290052 ] Sean R. Owen commented on SPARK-34448: -- Yes I believe you're definitely correct there's a problem

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-23 Thread Yakov Kerzhner (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289113#comment-17289113 ] Yakov Kerzhner commented on SPARK-34448: As I said in the description, I do not believe that the

[jira] [Commented] (SPARK-34448) Binary logistic regression incorrectly computes the intercept and coefficients when data is not centered

2021-02-22 Thread Sean R. Owen (Jira)
[ https://issues.apache.org/jira/browse/SPARK-34448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288806#comment-17288806 ] Sean R. Owen commented on SPARK-34448: -- So one coarse response is - I'm surprised if the