[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-09 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353826#comment-14353826 ] Sean Owen commented on SPARK-6142: -- Is this resolved by reverting those commits then? >

[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-06 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350163#comment-14350163 ] Sean Owen commented on SPARK-6142: -- Yeah that makes sense. I agree that finalize() isn't

[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-06 Thread Nishkam Ravi (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350154#comment-14350154 ] Nishkam Ravi commented on SPARK-6142: - [~srowen] GC takes at least one extra cycle for

[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-06 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350129#comment-14350129 ] Sean Owen commented on SPARK-6142: -- [~nravi] what's the overhead -- do objects only go on

[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-05 Thread Nishkam Ravi (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349646#comment-14349646 ] Nishkam Ravi commented on SPARK-6142: - [~zsxwing]Yes, the 10-12% regression was ve

[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-05 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348452#comment-14348452 ] Sean Owen commented on SPARK-6142: -- Yeah I'm curious how this change would affect perform

[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-05 Thread Shixiong Zhu (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348444#comment-14348444 ] Shixiong Zhu commented on SPARK-6142: - @nishkamravi2 I tested in our environment, and

[jira] [Commented] (SPARK-6142) 10-12% Performance regression with "finalize"

2015-03-03 Thread Nishkam Ravi (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346086#comment-14346086 ] Nishkam Ravi commented on SPARK-6142: - Fixed (master 9af001749a37a86ccbf78063ec514a218