Adrian Ionescu created SPARK-20255:
--------------------------------------

             Summary: FileIndex hierarchy inconsistency
                 Key: SPARK-20255
                 URL: https://issues.apache.org/jira/browse/SPARK-20255
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 2.1.0
            Reporter: Adrian Ionescu
            Priority: Minor


Trying to get a grip on the {{FileIndex}} hierarchy, I was confused by the 
following inconsistency: 

On the one hand, {{PartitioningAwareFileIndex}} defines {{leafFiles}} and 
{{leafDirToChildrenFiles}} as abstract, but on the other it fully implements 
{{listLeafFiles}} which does all the listing of files. However, the latter is 
only used by {{InMemoryFileIndex}}.

I'm hereby proposing to move this method (and all its dependencies) to the 
implementation class that actually uses it, and thus unclutter the 
{{PartitioningAwareFileIndex}} interface.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to