Andrew Ash created SPARK-21875: ---------------------------------- Summary: Jenkins passes Java code that violates ./dev/lint-java Key: SPARK-21875 URL: https://issues.apache.org/jira/browse/SPARK-21875 Project: Spark Issue Type: Bug Components: Build Affects Versions: 2.2.0 Reporter: Andrew Ash
Two recent PRs merged which caused lint-java errors: {noformat} ======================================================================== Running Java style checks ======================================================================== Using `mvn` from path: /home/ubuntu/spark/build/apache-maven-3.5.0/bin/mvn Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/memory/TaskMemoryManager.java:[77] (sizes) LineLength: Line is longer than 100 characters (found 106). [ERROR] src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:[1340] (sizes) LineLength: Line is longer than 100 characters (found 106). [error] running /home/ubuntu/spark/dev/lint-java ; received return code 1 {noformat} The first error is from https://github.com/apache/spark/pull/19025 and the second is from https://github.com/apache/spark/pull/18488 Should we be expecting Jenkins to enforce Java code style pre-commit? -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org