Armin Braun created SPARK-21967:
-----------------------------------

             Summary: org.apache.spark.unsafe.types.UTF8String#compareTo Should 
Compare 8 Bytes at a Time for Better Performance
                 Key: SPARK-21967
                 URL: https://issues.apache.org/jira/browse/SPARK-21967
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 2.2.0
            Reporter: Armin Braun
            Priority: Minor


org.apache.spark.unsafe.types.UTF8String#compareTo contains the following TODO:

{code}
    int len = Math.min(numBytes, other.numBytes);
    // TODO: compare 8 bytes as unsigned long
    for (int i = 0; i < len; i ++) {
      // In UTF-8, the byte should be unsigned, so we should compare them as 
unsigned int.
{code}

The todo should be resolved by comparing the maximum number of 64bit words 
possible in this method, before falling back to unsigned int comparison.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to