Maciej Szymkiewicz created SPARK-29363:
------------------------------------------
Summary: o.a.s.ml.regression.Regressor should be public
Key: SPARK-29363
URL: https://issues.apache.org/jira/browse/SPARK-29363
Project: Spark
Issue Type: Improvement
Components: ML
Affects Versions: 2.4.4, 2.3.0, 3.0.0
Reporter: Maciej Szymkiewicz
At the moment
[{{o.a.s.ml.regression.Regressor}}|https://github.com/apache/spark/blob/8556710409d9f2fbaee9dbf76a2ea70218316693/mllib/src/main/scala/org/apache/spark/ml/regression/Regressor.scala#L31]
is marked as {{private[spark]}}.
This however is inconsistent with the rest of the API:
* Similarly positioned {{o.a.s.ml.classification.Classifier}} [is
public|https://github.com/apache/spark/blob/7955b3962ac46b89564e0613db7bea98a1478bf2/mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala#L57-L58].
* Accompanying {{o.a.s.regression.RegressionModel}} [is
public|https://github.com/apache/spark/blob/8556710409d9f2fbaee9dbf76a2ea70218316693/mllib/src/main/scala/org/apache/spark/ml/regression/Regressor.scala#L49]
Additionally it hides useful information from the end user, who might be
interested in defining methods which operate specifically on {{Regressors}}
(should other regressor-like {{Estimators}} extend {{Regressor}} as well? Let's
say {{DecisionTreeRegressor}}).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
