[ https://issues.apache.org/jira/browse/SPARK-20936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved SPARK-20936. ------------------------------- Resolution: Fixed Fix Version/s: 2.3.0 Issue resolved by pull request 18158 [https://github.com/apache/spark/pull/18158] > Lack of an important case about the test of resolveURI > ------------------------------------------------------ > > Key: SPARK-20936 > URL: https://issues.apache.org/jira/browse/SPARK-20936 > Project: Spark > Issue Type: Bug > Components: Spark Core > Affects Versions: 2.1.1 > Reporter: zuotingbing > Priority: Minor > Fix For: 2.3.0 > > > 1. add `assert(resolve(before) === after)` to check before and after in test > of resolveURI. > the function `assertResolves(before: String, after: String)` have two > params, it means we should check the before value whether equals the after > value which we want. > e.g. the after value of > Utils.resolveURI("hdfs:///root/spark.jar#app.jar").toString should be > "hdfs:///root/spark.jar#app.jar" rather than "hdfs:/root/spark.jar#app.jar". > we need `assert(resolve(before) === after)` to make it more safe. > 2. identify the cases between resolveURI and resolveURIs. > 3. delete duplicate cases and some small fix make this suit more clear. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org