[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=876897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876897 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on pull request #731: WW-5334 Misc VelocityManager code cleanup

kusalk commented on PR #731: URL: https://github.com/apache/struts/pull/731#issuecomment-1683283675 Hmm we need to rethink the Maven module setup to avoid cyclic dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [struts] sepe81 commented on a diff in pull request #728: Defines a proper CODEOWNERS file

sepe81 commented on code in PR #728: URL: https://github.com/apache/struts/pull/728#discussion_r1297743026 ## CODEOWNERS: ## @@ -0,0 +1,2 @@ +# Request PR review from any Apache Struts committer +* @apache/struts-committers Review Comment: But where exactly are all struts-co

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=876791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876791 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #727: [WW-5331] Uses proper signature of get()

sonarcloud[bot] commented on PR #727: URL: https://github.com/apache/struts/pull/727#issuecomment-1682123364 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=876783&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876783 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #727: [WW-5331] Uses proper signature of get()

sonarcloud[bot] commented on PR #727: URL: https://github.com/apache/struts/pull/727#issuecomment-1682075438 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5327) Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

[ https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=876764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876764 ] ASF GitHub Bot logged work on WW-5327: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #730: Uses Java 17 to perform Code Quality check

sonarcloud[bot] commented on PR #730: URL: https://github.com/apache/struts/pull/730#issuecomment-1681963128 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5332) Validate excluded package name list for missing commas

[ https://issues.apache.org/jira/browse/WW-5332?focusedWorklogId=876763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876763 ] ASF GitHub Bot logged work on WW-5332: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a diff in pull request #730: Uses Java 17 to perform Code Quality check

lukaszlenart commented on code in PR #730: URL: https://github.com/apache/struts/pull/730#discussion_r1296942247 ## .github/workflows/maven.yml: ## @@ -49,10 +49,9 @@ jobs: distribution: adopt java-version: ${{ matrix.java }} - name: Build with Maven

[jira] [Created] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

Lukasz Lenart created WW-5335: - Summary: Adjusts Jenkins & Github build files to use JDK17 Key: WW-5335 URL: https://issues.apache.org/jira/browse/WW-5335 Project: Struts 2 Issue Type: Improvemen

[GitHub] [struts] lukaszlenart commented on a diff in pull request #728: Defines a proper CODEOWNERS file

lukaszlenart commented on code in PR #728: URL: https://github.com/apache/struts/pull/728#discussion_r1296929715 ## CODEOWNERS: ## @@ -0,0 +1,2 @@ +# Request PR review from any Apache Struts committer +* @apache/struts-committers Review Comment: Right... not sure why this te

[GitHub] [struts] sonarcloud[bot] commented on pull request #730: Uses Java 17 to perform Code Quality check

sonarcloud[bot] commented on PR #730: URL: https://github.com/apache/struts/pull/730#issuecomment-1681932725 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] kusalk commented on a diff in pull request #728: Defines a proper CODEOWNERS file

kusalk commented on code in PR #728: URL: https://github.com/apache/struts/pull/728#discussion_r1296923283 ## CODEOWNERS: ## @@ -0,0 +1,2 @@ +# Request PR review from any Apache Struts committer +* @apache/struts-committers Review Comment: Ah it might be complaining because

[GitHub] [struts] sonarcloud[bot] commented on pull request #730: Uses Java 17 to perform Code Quality check

sonarcloud[bot] commented on PR #730: URL: https://github.com/apache/struts/pull/730#issuecomment-1681915979 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] kusalk commented on a diff in pull request #728: Defines a proper CODEOWNERS file

kusalk commented on code in PR #728: URL: https://github.com/apache/struts/pull/728#discussion_r1296910324 ## CODEOWNERS: ## @@ -0,0 +1,2 @@ +# Request PR review from any Apache Struts committer +* @apache/struts-committers Review Comment: I think GitHub doesn't like the `*`

[GitHub] [struts] lukaszlenart commented on a diff in pull request #730: Uses Java 17 to perform Code Quality check

lukaszlenart commented on code in PR #730: URL: https://github.com/apache/struts/pull/730#discussion_r1296910009 ## .github/workflows/maven.yml: ## @@ -49,10 +49,9 @@ jobs: distribution: adopt java-version: ${{ matrix.java }} - name: Build with Maven

[GitHub] [struts] lukaszlenart commented on a diff in pull request #730: Uses Java 17 to perform Code Quality check

lukaszlenart commented on code in PR #730: URL: https://github.com/apache/struts/pull/730#discussion_r1296909727 ## .github/workflows/maven.yml: ## @@ -49,10 +49,9 @@ jobs: distribution: adopt java-version: ${{ matrix.java }} - name: Build with Maven

[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=876755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876755 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #731: WW-5334 Misc VelocityManager code cleanup

sonarcloud[bot] commented on PR #731: URL: https://github.com/apache/struts/pull/731#issuecomment-1681913381 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] kusalk commented on a diff in pull request #730: Uses Java 17 to perform Code Quality check

kusalk commented on code in PR #730: URL: https://github.com/apache/struts/pull/730#discussion_r1296908247 ## .github/workflows/maven.yml: ## @@ -49,10 +49,9 @@ jobs: distribution: adopt java-version: ${{ matrix.java }} - name: Build with Maven on Ja

[jira] [Work logged] (WW-5327) Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

[ https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=876754&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876754 ] ASF GitHub Bot logged work on WW-5327: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #730: Uses Java 17 to perform Code Quality check

kusalk commented on code in PR #730: URL: https://github.com/apache/struts/pull/730#discussion_r1296907684 ## .github/workflows/maven.yml: ## @@ -49,10 +49,9 @@ jobs: distribution: adopt java-version: ${{ matrix.java }} - name: Build with Maven on Ja

[GitHub] [struts] sonarcloud[bot] commented on pull request #729: [WW-5327] Removes duplicated exclusion

sonarcloud[bot] commented on PR #729: URL: https://github.com/apache/struts/pull/729#issuecomment-1681912351 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Commented] (WW-5334) Misc VelocityManager code cleanup

[ https://issues.apache.org/jira/browse/WW-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755439#comment-17755439 ] Lukasz Lenart commented on WW-5334: --- Is there any reason to target 6.4.0? 6.3.0 is still u

[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=876752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876752 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=876751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876751 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[jira] [Updated] (WW-5332) Validate excluded package name list for missing commas

[ https://issues.apache.org/jira/browse/WW-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5332: -- Fix Version/s: 6.3.0 (was: 6.4.0) > Validate excluded package name list for missing

[jira] [Work logged] (WW-5332) Validate excluded package name list for missing commas

[ https://issues.apache.org/jira/browse/WW-5332?focusedWorklogId=876748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876748 ] ASF GitHub Bot logged work on WW-5332: -- Author: ASF GitHub Bot

[jira] [Resolved] (WW-5332) Validate excluded package name list for missing commas

[ https://issues.apache.org/jira/browse/WW-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-5332. --- Resolution: Fixed > Validate excluded package name list for missing commas > ---

[jira] [Work logged] (WW-5327) Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

[ https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=876745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876745 ] ASF GitHub Bot logged work on WW-5327: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=876746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876746 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=876747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876747 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #727: [WW-5331] Uses proper signature of get()

sonarcloud[bot] commented on PR #727: URL: https://github.com/apache/struts/pull/727#issuecomment-1681901712 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] lukaszlenart commented on a diff in pull request #729: [WW-5327] Removes duplicated exclusion

lukaszlenart commented on code in PR #729: URL: https://github.com/apache/struts/pull/729#discussion_r1296898887 ## core/src/main/resources/struts-excluded-classes.xml: ## @@ -38,8 +38,7 @@ java.lang.Thread, sun.misc.Unsafe, com

[jira] [Created] (WW-5334) Misc VelocityManager code cleanup

Kusal Kithul-Godage created WW-5334: --- Summary: Misc VelocityManager code cleanup Key: WW-5334 URL: https://issues.apache.org/jira/browse/WW-5334 Project: Struts 2 Issue Type: Improvement

[jira] [Work logged] (WW-5327) Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

[ https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=876744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876744 ] ASF GitHub Bot logged work on WW-5327: -- Author: ASF GitHub Bot

[jira] [Updated] (WW-5332) Validate excluded package name list for missing commas

[ https://issues.apache.org/jira/browse/WW-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage updated WW-5332: Component/s: Core > Validate excluded package name list for missing commas > -

[GitHub] [struts] sonarcloud[bot] commented on pull request #729: [WW-5327] Removes duplicated exclusion

sonarcloud[bot] commented on PR #729: URL: https://github.com/apache/struts/pull/729#issuecomment-1681897148 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5327) Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

[ https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=876743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876743 ] ASF GitHub Bot logged work on WW-5327: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #729: [WW-5327] Removes duplicated exclusion

kusalk commented on code in PR #729: URL: https://github.com/apache/struts/pull/729#discussion_r1296891243 ## core/src/main/resources/struts-excluded-classes.xml: ## @@ -38,8 +38,7 @@ java.lang.Thread, sun.misc.Unsafe, com.opens

[jira] [Work logged] (WW-5327) Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

[ https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=876742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876742 ] ASF GitHub Bot logged work on WW-5327: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a diff in pull request #715: [WW-5327] Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

lukaszlenart commented on code in PR #715: URL: https://github.com/apache/struts/pull/715#discussion_r1296886230 ## core/src/main/resources/struts-excluded-classes.xml: ## @@ -37,7 +37,9 @@ java.lang.ProcessBuilder, java.lang.Thread,

[jira] [Work logged] (WW-5327) Stop using JavaBeans notation for setters in SecurityMemberAccess & MemberAccessValueStack

[ https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=876741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876741 ] ASF GitHub Bot logged work on WW-5327: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #728: Defines a proper CODEOWNERS file

sonarcloud[bot] commented on PR #728: URL: https://github.com/apache/struts/pull/728#issuecomment-1681876808 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=876735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876735 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #727: [WW-5331] Uses proper signature of get()

sonarcloud[bot] commented on PR #727: URL: https://github.com/apache/struts/pull/727#issuecomment-1681862426 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=876734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876734 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=876732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876732 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[jira] [Created] (WW-5333) Refactor AttributeMap

Lukasz Lenart created WW-5333: - Summary: Refactor AttributeMap Key: WW-5333 URL: https://issues.apache.org/jira/browse/WW-5333 Project: Struts 2 Issue Type: Improvement Components: Core

[jira] [Updated] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5331: -- Fix Version/s: 6.3.0 > Access to request attributes via tags is broken > -

[jira] [Updated] (WW-5331) Access to request attributes via tags is broken

[ https://issues.apache.org/jira/browse/WW-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5331: -- Description: Accessing request attributes no longer works consistently in 6.2.0.  If you have the followi