[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877403 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #735: URL: https://github.com/apache/struts/pull/735#issuecomment-1687561188 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877401 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
kusalk commented on code in PR #735: URL: https://github.com/apache/struts/pull/735#discussion_r1301076946 ## core/src/test/java/org/apache/struts2/util/StrutsUtilTest.java: ## @@ -145,28 +147,51 @@ public void testGetContextMethod() { } -public void testMakeSelectL

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877400 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
kusalk commented on code in PR #735: URL: https://github.com/apache/struts/pull/735#discussion_r1301075562 ## core/src/main/resources/struts-beans.xml: ## @@ -198,7 +198,7 @@ - + Review Comment: Amended - I tend to favour the same line as sometimes comments

[GitHub] [struts] dependabot[bot] commented on pull request #722: Bump javax.servlet:javax.servlet-api from 3.0.1 to 3.1.0

2023-08-21 Thread via GitHub
dependabot[bot] commented on PR #722: URL: https://github.com/apache/struts/pull/722#issuecomment-1687530796 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [struts] sonarcloud[bot] commented on pull request #737: Drops duplicated dependency

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #737: URL: https://github.com/apache/struts/pull/737#issuecomment-1687485139 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877393 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] sepe81 commented on a diff in pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
sepe81 commented on code in PR #735: URL: https://github.com/apache/struts/pull/735#discussion_r1300954436 ## core/src/main/resources/struts-beans.xml: ## @@ -198,7 +198,7 @@ - + Review Comment: Maybe it's better to put the comment before the bean? ##

[jira] [Commented] (WW-5334) Misc VelocityManager code cleanup

2023-08-21 Thread Kusal Kithul-Godage (Jira)
[ https://issues.apache.org/jira/browse/WW-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757173#comment-17757173 ] Kusal Kithul-Godage commented on WW-5334: - [~lukaszlenart] Didn't realise 6.3.0 was

[jira] [Resolved] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread Kusal Kithul-Godage (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage resolved WW-5337. - Resolution: Fixed > Improve performance of excluded classes and packages > -

[jira] [Reopened] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread Kusal Kithul-Godage (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage reopened WW-5337: - > Improve performance of excluded classes and packages > ---

[jira] [Updated] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread Kusal Kithul-Godage (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage updated WW-5337: Description: By using a HashSet#contains we can significantly improve performance for applicat

[jira] [Closed] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread Kusal Kithul-Godage (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage closed WW-5337. --- Resolution: Fixed > Improve performance of excluded classes and packages > -

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877381 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
kusalk commented on code in PR #735: URL: https://github.com/apache/struts/pull/735#discussion_r1300825252 ## core/src/main/java/org/apache/struts2/util/StrutsUtil.java: ## @@ -124,6 +123,17 @@ public Object findValue(String expression, String className) throws ClassNotFoun

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877380 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #735: URL: https://github.com/apache/struts/pull/735#issuecomment-1687303732 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877379 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #735: URL: https://github.com/apache/struts/pull/735#issuecomment-1687287134 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877378 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877360 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a diff in pull request #736: WW-5337 Make SecurityMemberAccess exclusion checking more performant

2023-08-21 Thread via GitHub
lukaszlenart commented on code in PR #736: URL: https://github.com/apache/struts/pull/736#discussion_r1300542828 ## core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessTest.java: ## @@ -178,23 +178,6 @@ public void testMiddleOfInheritanceExclusion3() throws Exce

[jira] [Resolved] (WW-5334) Misc VelocityManager code cleanup

2023-08-21 Thread Lukasz Lenart (Jira)
[ https://issues.apache.org/jira/browse/WW-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-5334. --- Resolution: Fixed > Misc VelocityManager code cleanup > - > >

[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=877359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877359 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[jira] [Updated] (WW-5334) Misc VelocityManager code cleanup

2023-08-21 Thread Lukasz Lenart (Jira)
[ https://issues.apache.org/jira/browse/WW-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5334: -- Fix Version/s: 6.3.0 (was: 6.4.0) > Misc VelocityManager code cleanup > ---

[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=877324&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877324 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877307&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877307 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #736: WW-5337 Make SecurityMemberAccess exclusion checking more performant

2023-08-21 Thread via GitHub
kusalk commented on code in PR #736: URL: https://github.com/apache/struts/pull/736#discussion_r1300194447 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -261,7 +262,8 @@ public void setDevModeExcludedPackageExemptClasses(String commaDelimitedClasses)

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877306 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #736: WW-5337 Make SecurityMemberAccess exclusion checking more performant

2023-08-21 Thread via GitHub
kusalk commented on code in PR #736: URL: https://github.com/apache/struts/pull/736#discussion_r1300194447 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -261,7 +262,8 @@ public void setDevModeExcludedPackageExemptClasses(String commaDelimitedClasses)

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877305 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on a diff in pull request #736: WW-5337 Make SecurityMemberAccess exclusion checking more performant

2023-08-21 Thread via GitHub
kusalk commented on code in PR #736: URL: https://github.com/apache/struts/pull/736#discussion_r1300194447 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -261,7 +262,8 @@ public void setDevModeExcludedPackageExemptClasses(String commaDelimitedClasses)

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877304 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #736: WW-5337 Make SecurityMemberAccess exclusion checking more performant

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #736: URL: https://github.com/apache/struts/pull/736#issuecomment-1686456196 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877293 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #735: URL: https://github.com/apache/struts/pull/735#issuecomment-1686425891 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877291 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] kusalk commented on pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
kusalk commented on PR #735: URL: https://github.com/apache/struts/pull/735#issuecomment-1686412267 Await merge of #731 first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877288&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877288 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #736: WW-5337 Make SecurityMemberAccess exclusion checking more performant

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #736: URL: https://github.com/apache/struts/pull/736#issuecomment-1686404293 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5334) Misc VelocityManager code cleanup

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=877286&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877286 ] ASF GitHub Bot logged work on WW-5334: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877284 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #735: WW-5336 Deprecate OgnlTool

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #735: URL: https://github.com/apache/struts/pull/735#issuecomment-1686387950 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5337) Improve performance of excluded classes and packages

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5337?focusedWorklogId=877279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877279 ] ASF GitHub Bot logged work on WW-5337: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=877278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877278 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[jira] [Resolved] (WW-5331) Access to request attributes via tags is broken

2023-08-21 Thread Lukasz Lenart (Jira)
[ https://issues.apache.org/jira/browse/WW-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-5331. --- Resolution: Fixed > Access to request attributes via tags is broken > --

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=877274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877274 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[GitHub] [struts] sonarcloud[bot] commented on pull request #727: [WW-5331] Uses proper signature of get()

2023-08-21 Thread via GitHub
sonarcloud[bot] commented on PR #727: URL: https://github.com/apache/struts/pull/727#issuecomment-1686306874 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5331) Access to request attributes via tags is broken

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=877272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877272 ] ASF GitHub Bot logged work on WW-5331: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a diff in pull request #727: [WW-5331] Uses proper signature of get()

2023-08-21 Thread via GitHub
lukaszlenart commented on code in PR #727: URL: https://github.com/apache/struts/pull/727#discussion_r1300087099 ## core/src/main/java/org/apache/struts2/dispatcher/ApplicationMap.java: ## @@ -117,12 +117,15 @@ public Object setValue(final Object obj) { * @param key the en

[jira] [Work logged] (WW-5336) Merge OgnlTool class into StrutsUtil class

2023-08-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5336?focusedWorklogId=877271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877271 ] ASF GitHub Bot logged work on WW-5336: -- Author: ASF GitHub Bot