[GitHub] [struts] kusalk commented on pull request #731: WW-5334 Misc VelocityManager code cleanup

2023-08-18 Thread via GitHub
kusalk commented on PR #731: URL: https://github.com/apache/struts/pull/731#issuecomment-1683913590 Will rebase and reopen after review and merge of #732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [struts] kusalk commented on pull request #731: WW-5334 Misc VelocityManager code cleanup

2023-08-18 Thread via GitHub
kusalk commented on PR #731: URL: https://github.com/apache/struts/pull/731#issuecomment-1683779615 > What do you mean by that? Since `struts2-junit-plugin` depends on other plugins (such as `struts2-convention-plugin`, `struts2-portlet-plugin`, `struts2-velocity-plugin`), it's impos

[GitHub] [struts] kusalk commented on pull request #731: WW-5334 Misc VelocityManager code cleanup

2023-08-17 Thread via GitHub
kusalk commented on PR #731: URL: https://github.com/apache/struts/pull/731#issuecomment-1683283675 Hmm we need to rethink the Maven module setup to avoid cyclic dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and