[ https://issues.apache.org/jira/browse/TEZ-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938376#comment-16938376 ]
TezQA commented on TEZ-4075: ---------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 3s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 43s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 24s{color} | {color:orange} tez-runtime-library: The patch generated 15 new + 259 unchanged - 1 fixed = 274 total (was 260) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 49s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 17s{color} | {color:green} tez-runtime-library in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 31m 44s{color} | {color:green} tez-tests in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 55s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 63m 48s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4075 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12981408/TEZ-4075.16.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile cc | | uname | Linux 83dbe4889922 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 7a3e378 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.0.1 | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/168/artifact/out/diff-checkstyle-tez-runtime-library.txt | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/168/testReport/ | | Max. process+thread count | 1209 (vs. ulimit of 5500) | | modules | C: tez-api tez-runtime-library tez-tests U: . | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/168/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Tez: Reimplement tez.runtime.transfer.data-via-events.enabled > ------------------------------------------------------------- > > Key: TEZ-4075 > URL: https://issues.apache.org/jira/browse/TEZ-4075 > Project: Apache Tez > Issue Type: Bug > Reporter: Gopal Vijayaraghavan > Assignee: Richard Zhang > Priority: Major > Attachments: TEZ-4075.10.patch, TEZ-4075.15.patch, TEZ-4075.16.patch, > Tez-4075.5.patch, Tez-4075.8.patch > > > This was factored out by TEZ-2196, which does skip buffers for 1-partition > data exchanges (therefore goes to disk directly). > {code} > if (shufflePayload.hasData()) { > shuffleManager.addKnownInput(shufflePayload.getHost(), > DataProto dataProto = shufflePayload.getData(); > shufflePayload.getPort(), srcAttemptIdentifier, srcIndex); > FetchedInput fetchedInput = > inputAllocator.allocate(dataProto.getRawLength(), > dataProto.getCompressedLength(), srcAttemptIdentifier); > moveDataToFetchedInput(dataProto, fetchedInput, hostIdentifier); > shuffleManager.addCompletedInputWithData(srcAttemptIdentifier, > fetchedInput); > } else { > shuffleManager.addKnownInput(shufflePayload.getHost(), > shufflePayload.getPort(), srcAttemptIdentifier, srcIndex); > } > {code} > got removed in > https://github.com/apache/tez/commit/1ba1f927c16a1d7c273b6cd1a8553e5269d1541a > It would be better to buffer up the 512Byte limit for the event size before > writing to disk, since creating a new file always incurs disk traffic, even > if the file is eventually being served out of the buffer cache. > The total overhead of receiving an event, then firing an HTTP call to fetch > the data etc adds approx 100-150ms to a query - the data xfer through the > event will skip the disk entirely for this & also remove the extra IOPS > incurred. > This channel is not suitable for large-scale event transport, but > specifically the workload here deals with 1-row control tables which consume > more bandwidth with HTTP headers and hostnames than the 93 byte payload. -- This message was sent by Atlassian Jira (v8.3.4#803005)