[GitHub] [tez] abstractdog commented on pull request #187: TEZ-4387: use new doclet API in Java 9+

2023-06-23 Thread via GitHub
abstractdog commented on PR #187: URL: https://github.com/apache/tez/pull/187#issuecomment-1604447879 this is strange, I wanted to test by building locally, but I can see that in jdk8 the problematic module is not included at all: ``` cd tez-tools mvn --batch-mode clean test-compile

[jira] [Resolved] (TEZ-4432) Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor resolved TEZ-4432. --- Resolution: Fixed > Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils > ---

[jira] [Updated] (TEZ-4432) Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-4432: -- Fix Version/s: 0.10.3 > Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils > -

[jira] [Commented] (TEZ-4432) Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736526#comment-17736526 ] László Bodor commented on TEZ-4432: --- merged to master, thanks [~ayushtkn] for the patch!

[GitHub] [tez] abstractdog merged pull request #297: TEZ-4432: Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils.

2023-06-23 Thread via GitHub
abstractdog merged PR #297: URL: https://github.com/apache/tez/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.or

[GitHub] [tez] tez-yetus commented on pull request #187: TEZ-4387: use new doclet API in Java 9+

2023-06-23 Thread via GitHub
tez-yetus commented on PR #187: URL: https://github.com/apache/tez/pull/187#issuecomment-1604330867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 27m 6s | Docker mode a

[GitHub] [tez] tez-yetus commented on pull request #297: TEZ-4432: Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils.

2023-06-23 Thread via GitHub
tez-yetus commented on PR #297: URL: https://github.com/apache/tez/pull/297#issuecomment-1604319232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s | Docker mode a

[jira] [Commented] (TEZ-4413) permission may not be set after crash

2023-06-23 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736497#comment-17736497 ] Ayush Saxena commented on TEZ-4413: --- Makes sense to me. Have raised a PR with the change!

[jira] [Assigned] (TEZ-4413) permission may not be set after crash

2023-06-23 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned TEZ-4413: - Assignee: Ayush Saxena > permission may not be set after crash > -

[jira] [Commented] (TEZ-4432) Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils

2023-06-23 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736496#comment-17736496 ] Ayush Saxena commented on TEZ-4432: --- Taking over. Have raised a PR with the change!!! >

[jira] [Assigned] (TEZ-4432) Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils

2023-06-23 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned TEZ-4432: - Assignee: Ayush Saxena > Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils > -

[GitHub] [tez] ayushtkn opened a new pull request, #297: TEZ-4432: Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils.

2023-06-23 Thread via GitHub
ayushtkn opened a new pull request, #297: URL: https://github.com/apache/tez/pull/297 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

[GitHub] [tez] tez-yetus commented on pull request #296: TEZ-4387: use new doclet API in Java 9+

2023-06-23 Thread via GitHub
tez-yetus commented on PR #296: URL: https://github.com/apache/tez/pull/296#issuecomment-1604278015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s | Docker mode a

[jira] [Commented] (TEZ-4437) file permission errors about StagingPath

2023-06-23 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736488#comment-17736488 ] Ayush Saxena commented on TEZ-4437: --- This isn't something doable IMO. The only way is to

[jira] [Resolved] (TEZ-4437) file permission errors about StagingPath

2023-06-23 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved TEZ-4437. --- Resolution: Won't Fix > file permission errors about StagingPath >

[jira] [Resolved] (TEZ-4472) Use unique DAG names in tests

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor resolved TEZ-4472. --- Resolution: Fixed > Use unique DAG names in tests > - > > K

[jira] [Commented] (TEZ-4472) Use unique DAG names in tests

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736475#comment-17736475 ] László Bodor commented on TEZ-4472: --- merged to master, thanks [~ayushtkn] for the patch!

[jira] [Updated] (TEZ-4472) Use unique DAG names in tests

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-4472: -- Fix Version/s: 0.10.3 > Use unique DAG names in tests > - > >

[jira] [Assigned] (TEZ-4437) file permission errors about StagingPath

2023-06-23 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned TEZ-4437: - Assignee: Ayush Saxena > file permission errors about StagingPath > --

[GitHub] [tez] tez-yetus commented on pull request #293: TEZ-4472: Use unique DAG names in tests.

2023-06-23 Thread via GitHub
tez-yetus commented on PR #293: URL: https://github.com/apache/tez/pull/293#issuecomment-1604045370 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s | Docker mode a

[jira] [Commented] (TEZ-4473) Remove pointless MDC_LOGGING message from logs if there is no custom MDC key

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736430#comment-17736430 ] László Bodor commented on TEZ-4473: --- merged to master, thanks [~ayushtkn] for the detaile

[jira] [Resolved] (TEZ-4473) Remove pointless MDC_LOGGING message from logs if there is no custom MDC key

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor resolved TEZ-4473. --- Resolution: Fixed > Remove pointless MDC_LOGGING message from logs if there is no custom MDC key >

[jira] [Updated] (TEZ-4473) Remove pointless MDC_LOGGING message from logs if there is no custom MDC key

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-4473: -- Fix Version/s: 0.10.3 > Remove pointless MDC_LOGGING message from logs if there is no custom MDC key > --

[GitHub] [tez] abstractdog merged pull request #294: TEZ-4473: Remove pointless MDC_LOGGING message from logs if there is no custom MDC key.

2023-06-23 Thread via GitHub
abstractdog merged PR #294: URL: https://github.com/apache/tez/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.or

[jira] [Commented] (TEZ-4250) Optimise TaskImpl::getCounters

2023-06-23 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736429#comment-17736429 ] László Bodor commented on TEZ-4250: --- the final patch is merged to master, thanks [~ayusht

[GitHub] [tez] tez-yetus commented on pull request #293: TEZ-4472: Use unique DAG names in tests.

2023-06-23 Thread via GitHub
tez-yetus commented on PR #293: URL: https://github.com/apache/tez/pull/293#issuecomment-1604006912 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s | Docker mode a

[GitHub] [tez] ayushtkn commented on pull request #294: TEZ-4473: Remove pointless MDC_LOGGING message from logs if there is no custom MDC key.

2023-06-23 Thread via GitHub
ayushtkn commented on PR #294: URL: https://github.com/apache/tez/pull/294#issuecomment-1603981179 The reason for the change lies here: https://issues.apache.org/jira/browse/TEZ-4473?focusedCommentId=17735558&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-

[GitHub] [tez] tez-yetus commented on pull request #295: TEZ-4250: Optimise TaskImpl::getCounters.

2023-06-23 Thread via GitHub
tez-yetus commented on PR #295: URL: https://github.com/apache/tez/pull/295#issuecomment-1603979054 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker mode a

[GitHub] [tez] abstractdog commented on pull request #293: TEZ-4472: Use unique DAG names in tests.

2023-06-23 Thread via GitHub
abstractdog commented on PR #293: URL: https://github.com/apache/tez/pull/293#issuecomment-1603895865 thanks @ayushtkn ! 1 more to address, can you please check TestLocalMode too? I remember that what my original headache that I workaround with something like (with respecting the junit para

[GitHub] [tez] abstractdog commented on pull request #295: TEZ-4250: Optimise TaskImpl::getCounters.

2023-06-23 Thread via GitHub
abstractdog commented on PR #295: URL: https://github.com/apache/tez/pull/295#issuecomment-1603887973 thanks for the review @rbalamohan LGTM also, only a minor nit, let me know if it makes sense -- This is an automated message from the Apache Git Service. To respond to the message, plea