[GitHub] [tez] abstractdog commented on pull request #115: TEZ-4300: Download protoc automatically compile/development time

2022-02-18 Thread GitBox
abstractdog commented on pull request #115: URL: https://github.com/apache/tez/pull/115#issuecomment-1044556894 @jteagles : could you please approve this patch? the installer script has been update according to comments in Jira, now it supports aarch64 too -- This is an automated mess

[GitHub] [tez] abstractdog commented on pull request #115: TEZ-4300: Download protoc automatically compile/development time

2022-01-12 Thread GitBox
abstractdog commented on pull request #115: URL: https://github.com/apache/tez/pull/115#issuecomment-1011024879 @jteagles : can I merge this to master? and push it to branch-0.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tez] abstractdog commented on pull request #115: TEZ-4300: Download protoc automatically compile/development time

2022-01-06 Thread GitBox
abstractdog commented on pull request #115: URL: https://github.com/apache/tez/pull/115#issuecomment-1006855776 checked, the patch works on branch-0.9 too, [this commit](https://github.com/abstractdog/tez/commit/f0f9923d782be9e4f6a0fedaae9f6f5103f89f06) contains a fix that I added on

[GitHub] [tez] abstractdog commented on pull request #115: TEZ-4300: Download protoc automatically compile/development time

2022-01-05 Thread GitBox
abstractdog commented on pull request #115: URL: https://github.com/apache/tez/pull/115#issuecomment-1006062756 it makes sense to try the patch out on branch-0.9 as it's only about using protobuf inside tez, let me try -- This is an automated message from the Apache Git Service. To respo

[GitHub] [tez] abstractdog commented on pull request #115: TEZ-4300: Download protoc automatically compile/development time

2021-12-27 Thread GitBox
abstractdog commented on pull request #115: URL: https://github.com/apache/tez/pull/115#issuecomment-1001528770 what do you think about this @jteagles? this would help with automatically handling different protoc versions, driven only by protobuf.version property -- This is an automated