[
https://issues.apache.org/jira/browse/TEZ-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079864#comment-14079864
]
Siddharth Seth commented on TEZ-1133:
-------------------------------------
[~airbots] - some comments on this patch.
- addLog4jSystemProperties is used by Hive at the moment, and shouldn't be
removed just yet. Not without an alternate if one exists.
- Likewise for getBaseMRConfiguration(Configuration conf)
- getMRAMJavaOpts is used by PIG - need to keep it for now
The changes for getBaseMRConfiguration(), addMROutput, mergeMRBinaryTokens look
good though.
Could you please upload another patch with these changes.
The original intent of this jira was to review all the methods and see if we
can consolidate some, remove others, provide alternates etc. That can be done
in a follow up. This can be used to remove APIs which we know are not used
elsewhere.
> Remove unnecessary MRHelpers methods or make them private
> ---------------------------------------------------------
>
> Key: TEZ-1133
> URL: https://issues.apache.org/jira/browse/TEZ-1133
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.4.1
> Reporter: Bikas Saha
> Assignee: Chen He
> Priority: Blocker
> Attachments: TEZ-1133.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
