[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130448#comment-14130448
]
Hitesh Shah commented on TEZ-1345:
--
Reverted commit for now as unit tests failed in build
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129680#comment-14129680
]
Jeff Zhang commented on TEZ-1345:
-
[~hitesh] Attach the new patch
* Remove vertexName in V
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128670#comment-14128670
]
Hitesh Shah commented on TEZ-1345:
--
Mostly looks good. 2 comments:
- any reason for usin
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128105#comment-14128105
]
Jeff Zhang commented on TEZ-1345:
-
bq. The changes in RecoveryParser.java - not sure why the
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127241#comment-14127241
]
Hitesh Shah commented on TEZ-1345:
--
Comments:
- The changes in RecoveryParser.java - not
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121752#comment-14121752
]
Hitesh Shah commented on TEZ-1345:
--
[~zjffdu] Changing VertexManagerPlugin is an incompatib
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121307#comment-14121307
]
Jeff Zhang commented on TEZ-1345:
-
[~bikassaha], [~hitesh] Thanks for your comments. The eff
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120399#comment-14120399
]
Bikas Saha commented on TEZ-1345:
-
Here is a summary from an offline discussion with Hitesh.
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120151#comment-14120151
]
Hitesh Shah commented on TEZ-1345:
--
Comments:
Regard patch 6:
- I am not sure this is
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119403#comment-14119403
]
Jeff Zhang commented on TEZ-1345:
-
[~hitesh] Attach 2 patches for the following 2 solutions:
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118474#comment-14118474
]
Hitesh Shah commented on TEZ-1345:
--
Regarding my comment on InputInitializerDoneEvent, it c
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118467#comment-14118467
]
Hitesh Shah commented on TEZ-1345:
--
What [~bikassaha] is recommending is to have the RootIn
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118470#comment-14118470
]
Hitesh Shah commented on TEZ-1345:
--
For TEZ-1156, lets address that in a separate jira.
>
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118463#comment-14118463
]
Hitesh Shah commented on TEZ-1345:
--
[~zjffdu] I am not sure how this last patch fixes the i
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117135#comment-14117135
]
Jeff Zhang commented on TEZ-1345:
-
Attach the patch.
* add inputName in InputDataInformatio
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115230#comment-14115230
]
Jeff Zhang commented on TEZ-1345:
-
[~bikassaha][~hitesh] I think maybe we could add the inp
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114081#comment-14114081
]
Bikas Saha commented on TEZ-1345:
-
There are 2 alternatives
1) pessimistic - save events be
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114025#comment-14114025
]
Hitesh Shah commented on TEZ-1345:
--
bq. So overall IMO, I prefer to ignore the init events
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113363#comment-14113363
]
Jeff Zhang commented on TEZ-1345:
-
[~bikassaha]
bq. Why are we calling VertexImpl method dir
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113324#comment-14113324
]
Bikas Saha commented on TEZ-1345:
-
Why are we calling VertexImpl method directly from the ve
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112796#comment-14112796
]
Bikas Saha commented on TEZ-1345:
-
Will look at the patch later today.
> Add checks to guar
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112675#comment-14112675
]
Hitesh Shah commented on TEZ-1345:
--
[~zjffdu] The approach should fix the issue. Minor nit:
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112176#comment-14112176
]
Jeff Zhang commented on TEZ-1345:
-
[~hitesh] Attach the new patch.
* Move the route events
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104551#comment-14104551
]
Hitesh Shah commented on TEZ-1345:
--
[~zjffdu] The code change is now causing handle() to be
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096356#comment-14096356
]
Jeff Zhang commented on TEZ-1345:
-
Attach the patch.
[~hitesh] I make the following change
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087823#comment-14087823
]
Hitesh Shah commented on TEZ-1345:
--
Sort of. In some cases, the vertex initialized event ge
[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087259#comment-14087259
]
Jeff Zhang commented on TEZ-1345:
-
[~hitesh] I found that there're 2 places where logging Ve
27 matches
Mail list logo