[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-11 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130448#comment-14130448 ] Hitesh Shah commented on TEZ-1345: -- Reverted commit for now as unit tests failed in build

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-10 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129680#comment-14129680 ] Jeff Zhang commented on TEZ-1345: - [~hitesh] Attach the new patch * Remove vertexName in V

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-10 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128670#comment-14128670 ] Hitesh Shah commented on TEZ-1345: -- Mostly looks good. 2 comments: - any reason for usin

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-09 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128105#comment-14128105 ] Jeff Zhang commented on TEZ-1345: - bq. The changes in RecoveryParser.java - not sure why the

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-09 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127241#comment-14127241 ] Hitesh Shah commented on TEZ-1345: -- Comments: - The changes in RecoveryParser.java - not

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-04 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121752#comment-14121752 ] Hitesh Shah commented on TEZ-1345: -- [~zjffdu] Changing VertexManagerPlugin is an incompatib

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-04 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121307#comment-14121307 ] Jeff Zhang commented on TEZ-1345: - [~bikassaha], [~hitesh] Thanks for your comments. The eff

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-03 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120399#comment-14120399 ] Bikas Saha commented on TEZ-1345: - Here is a summary from an offline discussion with Hitesh.

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-03 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120151#comment-14120151 ] Hitesh Shah commented on TEZ-1345: -- Comments: Regard patch 6: - I am not sure this is

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-02 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119403#comment-14119403 ] Jeff Zhang commented on TEZ-1345: - [~hitesh] Attach 2 patches for the following 2 solutions:

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-02 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118474#comment-14118474 ] Hitesh Shah commented on TEZ-1345: -- Regarding my comment on InputInitializerDoneEvent, it c

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-02 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118467#comment-14118467 ] Hitesh Shah commented on TEZ-1345: -- What [~bikassaha] is recommending is to have the RootIn

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-02 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118470#comment-14118470 ] Hitesh Shah commented on TEZ-1345: -- For TEZ-1156, lets address that in a separate jira. >

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-02 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118463#comment-14118463 ] Hitesh Shah commented on TEZ-1345: -- [~zjffdu] I am not sure how this last patch fixes the i

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-09-01 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117135#comment-14117135 ] Jeff Zhang commented on TEZ-1345: - Attach the patch. * add inputName in InputDataInformatio

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-29 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115230#comment-14115230 ] Jeff Zhang commented on TEZ-1345: - [~bikassaha][~hitesh] I think maybe we could add the inp

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-28 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114081#comment-14114081 ] Bikas Saha commented on TEZ-1345: - There are 2 alternatives 1) pessimistic - save events be

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-28 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114025#comment-14114025 ] Hitesh Shah commented on TEZ-1345: -- bq. So overall IMO, I prefer to ignore the init events

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-27 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113363#comment-14113363 ] Jeff Zhang commented on TEZ-1345: - [~bikassaha] bq. Why are we calling VertexImpl method dir

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-27 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113324#comment-14113324 ] Bikas Saha commented on TEZ-1345: - Why are we calling VertexImpl method directly from the ve

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-27 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112796#comment-14112796 ] Bikas Saha commented on TEZ-1345: - Will look at the patch later today. > Add checks to guar

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-27 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112675#comment-14112675 ] Hitesh Shah commented on TEZ-1345: -- [~zjffdu] The approach should fix the issue. Minor nit:

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-27 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112176#comment-14112176 ] Jeff Zhang commented on TEZ-1345: - [~hitesh] Attach the new patch. * Move the route events

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-20 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104551#comment-14104551 ] Hitesh Shah commented on TEZ-1345: -- [~zjffdu] The code change is now causing handle() to be

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-13 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096356#comment-14096356 ] Jeff Zhang commented on TEZ-1345: - Attach the patch. [~hitesh] I make the following change

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-06 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087823#comment-14087823 ] Hitesh Shah commented on TEZ-1345: -- Sort of. In some cases, the vertex initialized event ge

[jira] [Commented] (TEZ-1345) Add checks to guarantee all init events are written to recovery to consider vertex initialized

2014-08-05 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087259#comment-14087259 ] Jeff Zhang commented on TEZ-1345: - [~hitesh] I found that there're 2 places where logging Ve