[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-08 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091011#comment-14091011 ] Gopal V commented on TEZ-1372: -- Missed PreWarmVertex.java in diff? > Fix preWarm to work after

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-08 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090982#comment-14090982 ] Bikas Saha commented on TEZ-1372: - Yes. That what I intend to do per comment above. https://

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-07 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090353#comment-14090353 ] Siddharth Seth commented on TEZ-1372: - [~bikassaha], it'll be useful for the preWarm API

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-07 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089848#comment-14089848 ] Gopal V commented on TEZ-1372: -- [~bikassaha]: getting to this after HIVE-7601 and HIVE-7639 get

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-07 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089584#comment-14089584 ] Thaddeus Diamond commented on TEZ-1372: --- Yes we are sure of that. Thanks, this works.

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-07 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089513#comment-14089513 ] Bikas Saha commented on TEZ-1372: - If you want to override the sleep to something else then

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-06 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088761#comment-14088761 ] Thaddeus Diamond commented on TEZ-1372: --- Okay great. Set that config up and will igno

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-06 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088757#comment-14088757 ] Bikas Saha commented on TEZ-1372: - The intent is to remove the sleep. If its added as an API

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-06 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088545#comment-14088545 ] Thaddeus Diamond commented on TEZ-1372: --- Woops! I was trying to make it more "sample-l

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-06 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088178#comment-14088178 ] Bikas Saha commented on TEZ-1372: - [~gopalv] [~hitesh] Review please! > Fix preWarm to work

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-06 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087970#comment-14087970 ] Bikas Saha commented on TEZ-1372: - Thanks for trying it out. Why are you using MyDummyProc

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087212#comment-14087212 ] Thaddeus Diamond commented on TEZ-1372: --- Very nice. It's working. Got it to run with

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087176#comment-14087176 ] Thaddeus Diamond commented on TEZ-1372: --- Okay, could we up those two tests? Once I com

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087174#comment-14087174 ] Bikas Saha commented on TEZ-1372: - TestContainerReuse is known to occasionally fail. The tim

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087168#comment-14087168 ] Thaddeus Diamond commented on TEZ-1372: --- Varies every time but they typically are in t

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087165#comment-14087165 ] Bikas Saha commented on TEZ-1372: - Which tests? TestSecureShuffle is known and is being trac

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087162#comment-14087162 ] Thaddeus Diamond commented on TEZ-1372: --- Sorry, grabbed the first one accidentally. G

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087139#comment-14087139 ] Bikas Saha commented on TEZ-1372: - That latest patch builds fine for me. > Fix preWarm to w

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087133#comment-14087133 ] Thaddeus Diamond commented on TEZ-1372: --- This fails to build because the {{OrderedWord

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087045#comment-14087045 ] Bikas Saha commented on TEZ-1372: - [~gopalv] Let me know if creating a new class called PreW

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086839#comment-14086839 ] Thaddeus Diamond commented on TEZ-1372: --- This looks right on. I'll try it tomorrow (o

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086600#comment-14086600 ] Bikas Saha commented on TEZ-1372: - Attaching patch. [~thaddeus.diamond] Perhaps you can try

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086579#comment-14086579 ] Bikas Saha commented on TEZ-1372: - It will still be session.preWarm(FOO) where FOO is Vertex

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086223#comment-14086223 ] Thaddeus Diamond commented on TEZ-1372: --- Linking TEZ-1370 because this ticket was born

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-05 Thread Thaddeus Diamond (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086221#comment-14086221 ] Thaddeus Diamond commented on TEZ-1372: --- I like [~gopalv]'s idea, but am happy to make

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-04 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085750#comment-14085750 ] Gopal V commented on TEZ-1372: -- bq. 1) Remove PreWarmContext and startPreWarmContainers. Use Ve

[jira] [Commented] (TEZ-1372) Fix preWarm to work after recent API changes

2014-08-04 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085710#comment-14085710 ] Bikas Saha commented on TEZ-1372: - Plan or action 1) Remove PreWarmContext and startPreWarmC