[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204897#comment-14204897 ] Jeff Zhang commented on TEZ-1642: - Attach the patch. [~hitesh], please help review it Repro

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205000#comment-14205000 ] Hitesh Shah commented on TEZ-1642: -- Patch looks fine for the most part. How is printHisto

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205003#comment-14205003 ] Hitesh Shah commented on TEZ-1642: -- bq. using Thread.sleep to control whether vertex is par

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205578#comment-14205578 ] Jeff Zhang commented on TEZ-1642: - Run the test for the whole night. Unfortunately it fails

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205581#comment-14205581 ] Jeff Zhang commented on TEZ-1642: - bq. This can be controlled by using a custom vertex manag

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205599#comment-14205599 ] Hitesh Shah commented on TEZ-1642: -- What was the original failure being addressed? > Test

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205641#comment-14205641 ] Jeff Zhang commented on TEZ-1642: - The original failure is that AM is killed when vertex is

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205684#comment-14205684 ] Hitesh Shah commented on TEZ-1642: -- +1 after the logging comment above is addresed. > Test

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205736#comment-14205736 ] Jeff Zhang commented on TEZ-1642: - Committed to both master & branch-0.5 > TestAMRecovery s

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205766#comment-14205766 ] Hitesh Shah commented on TEZ-1642: -- [~zjffdu] Which patch was committed? There does not see

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205817#comment-14205817 ] Jeff Zhang commented on TEZ-1642: - [~hitesh], attach the new patch. But it fails again in my

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205823#comment-14205823 ] Hitesh Shah commented on TEZ-1642: -- [~zjffdu] Please revert the commit in that case. > Te

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205855#comment-14205855 ] Jeff Zhang commented on TEZ-1642: - commit reverted > TestAMRecovery sometimes fail > -

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206564#comment-14206564 ] Jeff Zhang commented on TEZ-1642: - [~hitesh], I find another issue that it is not guaranteed

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207421#comment-14207421 ] Jeff Zhang commented on TEZ-1642: - [~hitesh] Attach new patch. * Using the callback of Task

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207465#comment-14207465 ] Hitesh Shah commented on TEZ-1642: -- This is probably a bad idea. A better approach may to b

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207481#comment-14207481 ] Hitesh Shah commented on TEZ-1642: -- Can testVertexPartiallyFinished_XXX be achieved by only

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207494#comment-14207494 ] Jeff Zhang commented on TEZ-1642: - bq. Can testVertexPartiallyFinished_XXX be achieved by on

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207497#comment-14207497 ] Hitesh Shah commented on TEZ-1642: -- Also, it looks for a DAG with V0 -> V1, the VM of V1 is

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207505#comment-14207505 ] Jeff Zhang commented on TEZ-1642: - bq. Can testVertexPartiallyFinished_XXX be achieved by on

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207924#comment-14207924 ] Jeff Zhang commented on TEZ-1642: - It would be better to allow VM get the notification of Ta

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214433#comment-14214433 ] Jeff Zhang commented on TEZ-1642: - Attach a new patch, the main change in the patch is add t

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228086#comment-14228086 ] Bikas Saha commented on TEZ-1642: - The state change notifier change seems a bit heavy handed

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230843#comment-14230843 ] Jeff Zhang commented on TEZ-1642: - bq. Is the intent to fail the vertex after 1 task is fini

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231101#comment-14231101 ] Bikas Saha commented on TEZ-1642: - How crucial is it for task 2 to be running vs being incom

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251030#comment-14251030 ] Jeff Zhang commented on TEZ-1642: - Attach a new patch, [~bikassaha] [~hitesh] Please help r

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251061#comment-14251061 ] Bikas Saha commented on TEZ-1642: - Approach in the VM looks fine to me. Though I am not sure

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252644#comment-14252644 ] Hitesh Shah commented on TEZ-1642: -- +1 > TestAMRecovery sometimes fail > -

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252816#comment-14252816 ] Jeff Zhang commented on TEZ-1642: - Thanks for review. [~hitesh], [~bikassaha] Committed to

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286765#comment-14286765 ] Jeff Zhang commented on TEZ-1642: - backport it to branch-0.5 commit c033965e7ae582c91884c86

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286788#comment-14286788 ] Jeff Zhang commented on TEZ-1642: - Update master's CHANGES.txt : Move TEZ-1642, TEZ-1943 to

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286897#comment-14286897 ] Hitesh Shah commented on TEZ-1642: -- Can you also please update CHANGES.txt in branch-0.6?

[jira] [Commented] (TEZ-1642) TestAMRecovery sometimes fail

[ https://issues.apache.org/jira/browse/TEZ-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286907#comment-14286907 ] Jeff Zhang commented on TEZ-1642: - [~hitesh] Update CHANGES.txt in branch-0.6. commit c2062