[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517387#comment-14517387
]
Hitesh Shah commented on TEZ-2226:
--
Created TEZ-2380 for [~pramachandran]'s comment.
> Di
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517354#comment-14517354
]
Hitesh Shah commented on TEZ-2226:
--
Good catch [~pramachandran]. Will file a separate jira
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517127#comment-14517127
]
Prakash Ramachandran commented on TEZ-2226:
---
+1 LGTM.
one minor item (separate J
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516003#comment-14516003
]
TezQA commented on TEZ-2226:
{color:green}+1 overall{color}. Here are the results of testing th
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515843#comment-14515843
]
TezQA commented on TEZ-2226:
{color:green}+1 overall{color}. Here are the results of testing th
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515185#comment-14515185
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Thanks so much for the addon patch !
It looks very
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515186#comment-14515186
]
TezQA commented on TEZ-2226:
{color:green}+1 overall{color}. Here are the results of testing th
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515125#comment-14515125
]
Hitesh Shah commented on TEZ-2226:
--
Thanks for the patch 11 [~lichangleo]. I started making
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515120#comment-14515120
]
Chang Li commented on TEZ-2226:
---
Thanks a lot for help [~zjffdu], [~hitesh]! I updated my late
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513602#comment-14513602
]
Jeff Zhang commented on TEZ-2226:
-
I saw the TEZ_DAG_HISTORY_LOGGING is set in the dag's con
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511852#comment-14511852
]
TezQA commented on TEZ-2226:
{color:green}+1 overall{color}. Here are the results of testing th
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511769#comment-14511769
]
Hitesh Shah commented on TEZ-2226:
--
Not exactly. Based on your implementation, the history
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511723#comment-14511723
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Thanks for valuable review and feedback! I also fee
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511393#comment-14511393
]
Hitesh Shah commented on TEZ-2226:
--
One more point - recovery. Take this case:
- dag su
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511360#comment-14511360
]
TezQA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511340#comment-14511340
]
Hitesh Shah commented on TEZ-2226:
--
Thinking more about it - one option could be to introdu
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511335#comment-14511335
]
Hitesh Shah commented on TEZ-2226:
--
Comments:
{code}
} else {
d
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511303#comment-14511303
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Thanks a lot for this very comprehensive review! I
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503875#comment-14503875
]
Hitesh Shah commented on TEZ-2226:
--
Comments:
Replace TezDomainException with something m
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502903#comment-14502903
]
Chang Li commented on TEZ-2226:
---
[~hitesh], [~jeagles] could you please help review the latest
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495510#comment-14495510
]
TezQA commented on TEZ-2226:
{color:green}+1 overall{color}. Here are the results of testing th
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495196#comment-14495196
]
Chang Li commented on TEZ-2226:
---
[~jeagles] Thanks a lot! I just tried it on the new patch.
>
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495134#comment-14495134
]
TezQA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495103#comment-14495103
]
Jonathan Eagles commented on TEZ-2226:
--
[~lichangleo]. I haven't tried, but putting the
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495047#comment-14495047
]
Chang Li commented on TEZ-2226:
---
[~hitesh] The latest patch should fix the broken tests. Not s
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494945#comment-14494945
]
TezQA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494894#comment-14494894
]
Hitesh Shah commented on TEZ-2226:
--
Looked at the latest patch. Looks to be on the right tr
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494856#comment-14494856
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Have implemented two tests, which test multiple dag
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494263#comment-14494263
]
Chang Li commented on TEZ-2226:
---
[~jeagles] Thanks for identifying this issue. I will fix this
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494254#comment-14494254
]
Jonathan Eagles commented on TEZ-2226:
--
[~lichangleo], there is a problem with the TezD
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490431#comment-14490431
]
TezQA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490330#comment-14490330
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Thanks a lot for suggesting ways of writing tests a
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486198#comment-14486198
]
Hitesh Shah commented on TEZ-2226:
--
bq. However I am having some difficulties to write unit
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483324#comment-14483324
]
Chang Li commented on TEZ-2226:
---
TestMRRJobsDAGApi pass on my local machine
> Disable writing
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482260#comment-14482260
]
Hadoop QA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482196#comment-14482196
]
Chang Li commented on TEZ-2226:
---
[~hitesh] thanks for pointing out the problems. I have been r
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391163#comment-14391163
]
Hitesh Shah commented on TEZ-2226:
--
The patch does seem to have some inconsistencies in ter
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390645#comment-14390645
]
Chang Li commented on TEZ-2226:
---
[~hitesh] could you kindly help review the latest patch? Than
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388782#comment-14388782
]
Chang Li commented on TEZ-2226:
---
These two tests pass on my machine
> Disable writing history
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388724#comment-14388724
]
Hadoop QA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388705#comment-14388705
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Thanks for suggestion of proper changes. I have cha
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387516#comment-14387516
]
Hadoop QA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387500#comment-14387500
]
Hitesh Shah commented on TEZ-2226:
--
[~lichangleo] Should have clarified a bit more. I am tr
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387492#comment-14387492
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Thanks for point of correction. I just updated my p
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387438#comment-14387438
]
Hitesh Shah commented on TEZ-2226:
--
The approach to set timeline off if the error occurs du
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387148#comment-14387148
]
Hadoop QA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387047#comment-14387047
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Thanks for helping me understand the problem better
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384343#comment-14384343
]
Hitesh Shah commented on TEZ-2226:
--
[~lichangleo] I am not sure how this patch fixes the is
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384200#comment-14384200
]
Hadoop QA commented on TEZ-2226:
{color:red}-1 overall{color}. Here are the results of test
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384108#comment-14384108
]
Chang Li commented on TEZ-2226:
---
[~hitesh] Currently within createTimelineDomain, the failure
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383888#comment-14383888
]
Chang Li commented on TEZ-2226:
---
[~hitesh] no problem, I will work on this
> Disable writing
[
https://issues.apache.org/jira/browse/TEZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383042#comment-14383042
]
Hitesh Shah commented on TEZ-2226:
--
[~lichangleo] Would you mind taking a look at this too?
52 matches
Mail list logo
