[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129641#comment-14129641
]
Jeff Zhang commented on TEZ-850:
[~hitesh] Update the patch removing the "//TODO "
Maybe it i
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129623#comment-14129623
]
Hitesh Shah commented on TEZ-850:
-
Question on "//TODO something wrong" in the patch - could
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129618#comment-14129618
]
Hitesh Shah commented on TEZ-850:
-
[~zjffdu] they are showing up in Intellij. I am not sure w
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129615#comment-14129615
]
Jeff Zhang commented on TEZ-850:
[~hitesh] Attach the patch. BTW, could you let me know what
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129596#comment-14129596
]
Hitesh Shah commented on TEZ-850:
-
There were minor warnings for example:
- instead of us
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129566#comment-14129566
]
Jeff Zhang commented on TEZ-850:
Attach the new patch.
* rebase it
* remove MockVertexImpl w
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129117#comment-14129117
]
Hitesh Shah commented on TEZ-850:
-
Comments on patch:
- needs a minor rebase
- MockVert
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127876#comment-14127876
]
Jeff Zhang commented on TEZ-850:
Attach the new patch (add VisibleForTesting annotation)
Cre
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127356#comment-14127356
]
Hitesh Shah commented on TEZ-850:
-
Mostly looks fine.
Couple of minor comments:
- for fi
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102070#comment-14102070
]
Jeff Zhang commented on TEZ-850:
[~hitesh] Attach the patch.
* Recovery Unit test for DAG, V
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100889#comment-14100889
]
Hitesh Shah commented on TEZ-850:
-
[~zjffdu] Correct - the current tests are high level compl
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100295#comment-14100295
]
Jeff Zhang commented on TEZ-850:
[~hitesh] There's already a class for this kind of test: Tes
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095078#comment-14095078
]
Hitesh Shah commented on TEZ-850:
-
There may be other cases that may require running jobs sim
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090416#comment-14090416
]
Jeff Zhang commented on TEZ-850:
[~hitesh], I have done some work on this. But considering th
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089194#comment-14089194
]
Jeff Zhang commented on TEZ-850:
Start working on this
> Recovery unit tests
> -
15 matches
Mail list logo
