[GitHub] trafficserver pull request #798: TS-4653: esi plugin - disable HTTP_COOKIE v...

2016-07-20 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/798 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25751 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Cre

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25750 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #798: TS-4653: esi plugin - disable HTTP_COOKIE variable...

2016-07-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/798 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/353/ for details. --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25749 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #798: TS-4653: esi plugin - disable HTTP_COOKIE variable...

2016-07-20 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/798 updated just now. will merge after squashing commits into one. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Work logged] (TS-4612) Proposal: InactivityCop Optimize

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4612?focusedWorklogId=25748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25748 ] ASF GitHub Bot logged work on TS-4612: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-20 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/771#discussion_r71512654 --- Diff: iocore/net/UnixNet.cc --- @@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e) epd = (EventIO *)get_ev_data(pd, x);

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25746 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Cre

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25745 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #798: TS-4653: esi plugin - disable HTTP_COOKIE variable...

2016-07-20 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/798 @shukitchan Overall it looks good. I had one minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] trafficserver pull request #798: TS-4653: esi plugin - disable HTTP_COOKIE v...

2016-07-20 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/798#discussion_r71495348 --- Diff: plugins/experimental/esi/lib/Variables.cc --- @@ -357,9 +357,25 @@ Variables::_parseCookieString(const char *str, int str_len) Attri

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-20 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/771#discussion_r71490427 --- Diff: iocore/net/UnixNet.cc --- @@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e) epd = (EventIO *)get_ev_data(pd, x);

[jira] [Work logged] (TS-4612) Proposal: InactivityCop Optimize

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4612?focusedWorklogId=25744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25744 ] ASF GitHub Bot logged work on TS-4612: -- Author: ASF GitHub Bot Cre

[jira] [Work logged] (TS-4612) Proposal: InactivityCop Optimize

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4612?focusedWorklogId=25743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25743 ] ASF GitHub Bot logged work on TS-4612: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize

2016-07-20 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/771#discussion_r71490006 --- Diff: iocore/net/UnixNet.cc --- @@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e) epd = (EventIO *)get_ev_data(pd, x);

[jira] [Work logged] (TS-4652) ASAN issue in logging with gcc 6.1.1

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4652?focusedWorklogId=25742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25742 ] ASF GitHub Bot logged work on TS-4652: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #813: TS-4652 Fixes log field initialization, previously...

2016-07-20 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/813 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25741 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #798: TS-4653: esi plugin - disable HTTP_COOKIE variable...

2016-07-20 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/798 @sudheerv can you help to do a review for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

<    1   2