[jira] [Comment Edited] (TS-4548) Convert custom log config file to Lua

2016-07-28 Thread James Peach (JIRA)
[ https://issues.apache.org/jira/browse/TS-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398729#comment-15398729 ] James Peach edited comment on TS-4548 at 7/29/16 5:24 AM: -- Straw man syntax

[jira] [Commented] (TS-4548) Convert custom log config file to Lua

2016-07-28 Thread James Peach (JIRA)
[ https://issues.apache.org/jira/browse/TS-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398729#comment-15398729 ] James Peach commented on TS-4548: - Straw man syntax proposal: {{noformat}} minimal = format { Format = "%

[jira] [Assigned] (TS-4548) Convert custom log config file to Lua

2016-07-28 Thread James Peach (JIRA)
[ https://issues.apache.org/jira/browse/TS-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach reassigned TS-4548: --- Assignee: James Peach > Convert custom log config file to Lua > - >

Build failed in Jenkins: centos_7-master ยป clang,centos_7,debug #1876

2016-07-28 Thread jenkins
See -- [...truncated 18060 lines...] 0|0|145.111.0.0|145.111.0.0|per_ip| |F|0|0|1970/01/01 00:00:00|4310273191177806975|0|0|1|0 RPRINT

[jira] [Commented] (TS-3620) Enable HTTP/2 by default

2016-07-28 Thread James Peach (JIRA)
[ https://issues.apache.org/jira/browse/TS-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398630#comment-15398630 ] James Peach commented on TS-3620: - As seen on IRC, this ought to update the default ``server_ports`` too. >

[jira] [Work logged] (TS-4699) Add an example websocket termination plugin using the C++ API

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4699?focusedWorklogId=26085=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26085 ] ASF GitHub Bot logged work on TS-4699: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732848 --- Diff: lib/atscppapi/examples/experimental/websocket/WSBuffer.cc --- @@ -0,0 +1,206 @@ +#include "WSBuffer.hh" + +#include

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732703 --- Diff: lib/atscppapi/examples/Makefile.am --- @@ -15,6 +15,8 @@ # See the License for the specific language governing permissions and #

[jira] [Work logged] (TS-4699) Add an example websocket termination plugin using the C++ API

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4699?focusedWorklogId=26084=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26084 ] ASF GitHub Bot logged work on TS-4699: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4699) Add an example websocket termination plugin using the C++ API

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4699?focusedWorklogId=26082=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26082 ] ASF GitHub Bot logged work on TS-4699: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4699) Add an example websocket termination plugin using the C++ API

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4699?focusedWorklogId=26083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26083 ] ASF GitHub Bot logged work on TS-4699: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732656 --- Diff: lib/atscppapi/examples/experimental/websocket/WSBuffer.hh --- @@ -0,0 +1,69 @@ +#ifndef WS_BUFFER_HH_HEADERS_ +#define

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732670 --- Diff: lib/atscppapi/examples/experimental/websocket/WSBuffer.cc --- @@ -0,0 +1,206 @@ +#include "WSBuffer.hh" --- End diff -- Needs

[jira] [Work logged] (TS-4699) Add an example websocket termination plugin using the C++ API

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4699?focusedWorklogId=26081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26081 ] ASF GitHub Bot logged work on TS-4699: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732562 --- Diff: lib/atscppapi/examples/experimental/websocket/WebSocket.cc --- @@ -0,0 +1,132 @@ +#include "WebSocket.hh" + +#include

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-07-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/823 We don't really use event return values outside of event handlers, so if we return a failure from ``accept()``, it should just be a ``bool``. Originally, the contract for

[jira] [Work logged] (TS-4697) MIOBuffer is not freed if ipallow check fails in HttpSessionAccept::accept()

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4697?focusedWorklogId=26080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26080 ] ASF GitHub Bot logged work on TS-4697: -- Author: ASF GitHub Bot Created

[jira] [Commented] (TS-4475) Crash in Log-Collation client after using inactivity-cop.

2016-07-28 Thread Peter Chou (JIRA)
[ https://issues.apache.org/jira/browse/TS-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398056#comment-15398056 ] Peter Chou commented on TS-4475: I submitted a PR with a fix so that the Log Collation Client SM will treat

[jira] [Work logged] (TS-4475) Crash in Log-Collation client after using inactivity-cop.

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4475?focusedWorklogId=26079=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26079 ] ASF GitHub Bot logged work on TS-4475: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #831: TS-4475: Log Collation Client SM, added VC_...

2016-07-28 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/831 TS-4475: Log Collation Client SM, added VC_EVENT_INACTIVITY_TIMEOUT event handling. Previously, this event was un-handled and would cause a core dump when it happened. This event is now

[jira] [Work logged] (TS-4554) ASAN crash (stack overflow) with H2 priorities

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4554?focusedWorklogId=26049=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26049 ] ASF GitHub Bot logged work on TS-4554: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #830: TS-4554: Set max depth of Http2DependencyTree

2016-07-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/830 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/386/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #830: TS-4554: Set max depth of Http2DependencyTree

2016-07-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/830 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/489/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4554) ASAN crash (stack overflow) with H2 priorities

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4554?focusedWorklogId=26048=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26048 ] ASF GitHub Bot logged work on TS-4554: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4554) ASAN crash (stack overflow) with H2 priorities

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4554?focusedWorklogId=26047=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26047 ] ASF GitHub Bot logged work on TS-4554: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #830: TS-4554: Set max depth of Http2DependencyTr...

2016-07-28 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/830 TS-4554: Set max depth of Http2DependencyTree - Set max depth of Http2DependencyTree When the depth over the maximum, new node will be a children of root node. - Remove node from

[jira] [Work logged] (TS-4703) Adds an API call to retrieve transaction protocol

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=26046=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26046 ] ASF GitHub Bot logged work on TS-4703: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #829: TS-4703: Adds an API call to retrieve transaction ...

2016-07-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/829 I'm quite negative on this API and the underlying "get_protocol_string()". I think that it doesn't serve the right purpose and is not general enough to be useful. See dev@ for more discussion.

[jira] [Work logged] (TS-4703) Adds an API call to retrieve transaction protocol

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=26045=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26045 ] ASF GitHub Bot logged work on TS-4703: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #829: TS-4703: Adds an API call to retrieve transaction ...

2016-07-28 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/829 That's good idea:) @petarpenkov would you add `TSHttpSsnClientProtocolGet(TSHttpSsn ssnp)` which is wrapper of `ProxyClientSession::get_protocol_string()` ? ( Session version of

[jira] [Work logged] (TS-4705) Proposal: NetVC Context

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=26044=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26044 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @bryancall update the enums. ``` NET_VCONNECTION_UNSET, NET_VCONNECTION_IN, // Client <--> ATS, Client-Side NET_VCONNECTION_OUT, // ATS <--> Server, Server-Side ```

[jira] [Commented] (TS-4696) CID 1267824: Missing unlock in mgmt/Alarms.cc

2016-07-28 Thread taoyunxing (JIRA)
[ https://issues.apache.org/jira/browse/TS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397262#comment-15397262 ] taoyunxing commented on TS-4696: Indeed, there exist two places return without releasing the mutex. > CID

[jira] [Work logged] (TS-4705) Proposal: NetVC Context

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=26043=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26043 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-07-28 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/753 @oknet AFAIK, it's same. Please set type of JIRA 'improvement'. Currently all code changes are tracked by JIRA. --- If your project is set up for it, you can reply to this email and have

[jira] [Work logged] (TS-4705) Proposal: NetVC Context

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4705?focusedWorklogId=26042=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26042 ] ASF GitHub Bot logged work on TS-4705: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @masaori335 JIRA issue created. BTW what is the proposal review progress ? Is it same as the bug report progress ? create JIRA issue then create PR ? --- If your project is set up for

[jira] [Work logged] (TS-4703) Adds an API call to retrieve transaction protocol

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=26041=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26041 ] ASF GitHub Bot logged work on TS-4703: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #829: TS-4703: Adds an API call to retrieve transaction ...

2016-07-28 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/829 good point. Perhaps we can do it in this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (TS-4705) Proposal: NetVC Context

2016-07-28 Thread Oknet Xu (JIRA)
Oknet Xu created TS-4705: Summary: Proposal: NetVC Context Key: TS-4705 URL: https://issues.apache.org/jira/browse/TS-4705 Project: Traffic Server Issue Type: Improvement Components: Core

[jira] [Work logged] (TS-4703) Adds an API call to retrieve transaction protocol

2016-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=26040=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26040 ] ASF GitHub Bot logged work on TS-4703: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #829: TS-4703: Adds an API call to retrieve transaction ...

2016-07-28 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/829 @shukitchan I don't think so. We need one more API, `TSHttpSsnClientProtocolGet(TSHttpSsn ssnp)`, for TS-2987. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (TS-4614) In UnixNetVConnection::mainEvent should not do e->schedule_in for dummy event callback

2016-07-28 Thread Oknet Xu (JIRA)
[ https://issues.apache.org/jira/browse/TS-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397182#comment-15397182 ] Oknet Xu commented on TS-4614: -- What I should do for the backport ? > In UnixNetVConnection::mainEvent should

[GitHub] trafficserver issue #753: Proposal: NetVC Context

2016-07-28 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/753 BTW, which is JIRA ticket for this? And would you use the ticket number in commit message? Our commit log format requires it.

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-07-28 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r72574922 --- Diff: iocore/net/UnixConnection.cc --- @@ -320,14 +320,15 @@ Connection::connect(sockaddr const *target, NetVCOptions const ) int

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r72571991 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -1296,7 +1294,7 @@ UnixNetVConnection::connectUp(EThread *t, int fd) } if (fd ==

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-07-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r72571589 --- Diff: iocore/net/UnixConnection.cc --- @@ -320,14 +320,15 @@ Connection::connect(sockaddr const *target, NetVCOptions const ) int res;