[jira] [Work logged] (TS-4750) Erroneous WARNING: Connection leak from http keep-alive system

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4750?focusedWorklogId=26420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26420 ] ASF GitHub Bot logged work on TS-4750: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-14 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/863 The change seems reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26419 ] ASF GitHub Bot logged work on TS-2237: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver pull request #866: TS-2237: Fix double encoding of URLs in squ...

2016-08-14 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/866#discussion_r74707817 --- Diff: proxy/logging/LogUtils.cc --- @@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t len_in, int *len_out, cha whil

[GitHub] trafficserver pull request #866: TS-2237: Fix double encoding of URLs in squ...

2016-08-14 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/866#discussion_r74707669 --- Diff: proxy/logging/LogUtils.cc --- @@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t len_in, int *len_out, cha whil

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26418 ] ASF GitHub Bot logged work on TS-2237: -- Author: ASF GitHub Bot Cre

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26417 ] ASF GitHub Bot logged work on TS-2237: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver pull request #866: TS-2237: Fix double encoding of URLs in squ...

2016-08-14 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/866#discussion_r74707413 --- Diff: configure.ac --- @@ -49,7 +49,7 @@ AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability tar-ustar foreign no-installinf AM_MAINTAINER_MODE([en

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26416 ] ASF GitHub Bot logged work on TS-2237: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #866: TS-2237: Fix double encoding of URLs in squid logs...

2016-08-14 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/866 I wrote a unit test for CURRENT `escapify_url`. http://pastebin.com/XZ4x8bKg With your change, you would need to change the last expected value in the test cases. --- If your proj

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26415 ] ASF GitHub Bot logged work on TS-2237: -- Author: ASF GitHub Bot Cre

[GitHub] trafficserver issue #866: TS-2237: Fix double encoding of URLs in squid logs...

2016-08-14 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/866 I don't think this is the right approach. With this change, "%%20" will be encoded to "%25%20", right? What if "%%20" was not encoded string? It should be encoded to "%25%2520". Shouldn't w