[GitHub] trafficserver pull request #1453: MemView: Fix methods return type definitio...

2017-02-16 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] trafficserver pull request #1422: YTS-614: Avoid crash due to error during P...

2017-02-16 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] trafficserver issue #1422: YTS-614: Avoid crash due to error during POST req...

2017-02-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1422 We've been running this in production for months and it fixed a series of crashes in ATS for us. I think it should probably be backported to 7.1, Y! will be putting it in our 7.1 fork

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101526314 --- Diff: iocore/eventsystem/P_IOBuffer.h --- @@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i) }

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101527244 --- Diff: lib/ts/signals.cc --- @@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler) sigact = (void *)oact.sa

[GitHub] trafficserver pull request #1439: Add BIO_sock_non_fatal_error() attribution

2017-02-16 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

2017-02-16 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] trafficserver pull request #1456: Add TCP accept metric which tracks the tot...

2017-02-16 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/1456 Add TCP accept metric which tracks the total number of TCP connections accepted. `proxy.process.net.tcp.accept` This is useful to track the rate of inbound connections accep

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1563/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1457/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101558075 --- Diff: iocore/eventsystem/P_IOBuffer.h --- @@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i) } ink_releas

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101558553 --- Diff: lib/ts/signals.cc --- @@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler) sigact = (void *)oact.sa_sigaction

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/128/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1456 Why are there tsconfig changes with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request #1454: Updates to the help output for tsxs

2017-02-16 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101584542 --- Diff: lib/ts/signals.cc --- @@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler) sigact = (void *)oact.sa_sigaction

[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
GitHub user zizhong opened a pull request: https://github.com/apache/trafficserver/pull/1457 fix TS-4195: crash when stop trafficserver Because of `psiginfo`, `psignal` and `exit`, which call `malloc` and `free` inside `proxy_signal_handler`. ATS will crash from time to time when st

[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1451 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1458/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1451 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1564/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1457 Is it still possible to use leak checkers that reconcile at exit after this fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #1458: Removed spaces at the end of the line on a...

2017-02-16 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1458 Removed spaces at the end of the line on all files Removed spaces at the end of the line on all files doing: `find . -type f | grep -v '\.git' | xargs -n1 perl -pi -e 's/\s+\n$/\n/'`

[GitHub] trafficserver issue #1444: issue #1401: Potential fix to the write_to_io_net...

2017-02-16 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1444 Yes, as I said not an entirely satisfying solution. I do thing the issue is triggered by the changes from TS-4796 where @jacksontj added logic to bubble up these errors. I'm guessing in so

[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1451 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/129/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1565/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1459/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1566/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1460/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/130/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/131/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 @jpeach , I haven't tested it yet. I would like to try it. Then I configured it with `--enable-asan`, but got ``` checking whether compiling and linking against OpenSSL wor

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 I checked the config.log and found the problem. I didn't have `asan` installed. However, the error message here was quite misleading. --- If your project is set up for it, you can reply to t

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1461/ for details. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/132/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1567/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 Tested with `--enable-asan` and didn't find any issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 Sorry for the build failed. It's because missed a piece when merging the code. Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 Testing new ICC builds [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/1/ for details. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1568/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1462/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1459: Mysterious uptick in user_agent SSL errors moving...

2017-02-16 Thread shinrich
GitHub user shinrich opened an issue: https://github.com/apache/trafficserver/issues/1459 Mysterious uptick in user_agent SSL errors moving to 7.1 Comparing a machine running 7.1.x against its peer running our version of 5.3.x. A number of the proxy.process.ssl.user_agent_* metrics

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/2/ for details. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 Testing new ICC builds [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1569/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/3/ for details. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/133/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1463/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1570/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1464/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/134/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/4/ for details. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/135/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1450: Update to latest RAT version

2017-02-16 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1571/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1465/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/136/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1572/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/5/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1466/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver pull request #1458: Removed spaces at the end of the line on a...

2017-02-16 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/137/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1456 Bad merge, I'll fix the TSConfig stuff. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/6/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1573/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-16 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1460 Removes some unnecessary dependencies on the public ts/ts.h This also removes the proxy/api/ts directory from all default search paths, to make it more difficult to introduce more bad i

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1467/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1574/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/7/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1468/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/138/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zizhong No need to apologize, this is exactly why we have a CI / build system. :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1456 Hmmm, how is this different from proxy.process.http.total_incoming_connections ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/9/ for details. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] trafficserver pull request #1461: Changes debug builds with Intel to just -g

2017-02-16 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1461 Changes debug builds with Intel to just -g This gets rid of debug build warnings with Intel compilers. You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1575/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1469/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1576/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1470/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/139/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/8/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zwoop , in https://ci.trafficserver.apache.org/job/icc-github/9/ ``` checking whether the C compiler works... no configure: error: in `/var/jenkins/workspace/icc-github/src': c

[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/140/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/141/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Yeh, this failed because the Intel installation was not correct on one of the VMs. [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/10/ for details. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1461 Failed at ``` In file included from P_EventSystem.h(40), from EventSystem.cc(31): P_IOBuffer.h(697): error #1011: missing return statement at end of non-void f

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1471/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1577/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 Failed at ``` P_IOBuffer.h(697): error #1011: missing return statement at end of non-void function "IOBufferReader::operator[]" } ^ ``` I can try to fix it with ano

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/142/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Ah, that fails because you don't have the fixes I made on master. All you have to do is rebase your branch with current master, and push again. --- If your project is set up for it, you can re

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zwoop , thanks! Rebased and pushed again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/11/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1472/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1578/ for details. --- If your project is set up for it, you can reply to this email and have your

  1   2   >