[GitHub] trafficserver issue #1519: Update metrics.config and logging.config to new n...

2017-02-28 Thread shukitchan
GitHub user shukitchan opened an issue: https://github.com/apache/trafficserver/issues/1519 Update metrics.config and logging.config to new naming convention to metrics.luaconf and logging.luaconf accordingly. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver issue #1158: TS-5015: Convert storage configuration file to Lu...

2017-02-28 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1158 it looks like .luaconf is the winner. I will be updating this accordingly. Also will create new issue to make sure metrics.config and logging.config are changed accordingly as well.

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1516 the patch compiles fine. And it seems to run through clang-format as well already. thanks. pls check out the comments above. --- If your project is set up for it, you can reply to this e

[GitHub] trafficserver issue #1481: Log Field % always outputs "-"

2017-02-28 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/issues/1481 I'm not 100% sure but it seems https://github.com/apache/trafficserver/commit/dda9df7ca7b886b5fd54d3ff6e9ed4f741948ba3 broke it. I reproduced the issue on master. `LogAccessHttp::ma

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1446 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1551/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1446 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1655/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1446 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/87/ for details. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-02-28 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1446 Updated again to add some docs and fix again the state handling while traversing the hooks. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1445 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/218/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1445 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1550/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103610662 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + *

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1445 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1654/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1445: Issue #1443 - Fix early or duplicate 404 e...

2017-02-28 Thread shinrich
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1445 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/86/ for details. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

2017-02-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1445 I looked at this as well and it definitely looks like it's an artifact of a remap plugin setting the transaction to be an error. You can see that this happens in a switch statement wh

[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass

2017-02-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1472 "TS-3100: Extend tr-pass to allow malformed HTTP GET requests to be blind tunneled." is added by @shinrich . --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass

2017-02-28 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1472 It is fixed by “TS-5103: replace ua_raw_buffer_reader with ua_buffer_reader” please check the code in master branch. --- If your project is set up for it, you can reply to this email a

[GitHub] trafficserver issue #1503: client cert should be added to netvcoptions only ...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1503 Not sure I follow here, does this land on master? Or was the intent here to make a backport PR against 7.1.x branch? --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103590528 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void +CacheControlHe

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1516 will try to compile it tonight and see if i have more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103589725 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void +CacheControlHe

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1516 The max-age related code is also a bit different from before. Previously we can have max-age larger than 31536. Now with this change, I think we can no longer have max-age larger than

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1516 I am not in favor with the "private" related changes because i think it can catch some existing users by surprise. And we did not mention anything in the document as well - https://docs.t

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103587579 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103586416 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver issue #1511: heap-use-after-free: Access ua_session after Http...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1511 Also, can you put into the description what the problem is (like, when / how does it trigger), and what problem it causes? That really helps deciding severity, for backports etc., as well as fo

[GitHub] trafficserver issue #1511: heap-use-after-free: Access ua_session after Http...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1511 Is this a 7.1.x candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1518 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/217/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1518: Ensure 'service trafficserver stop’ is s...

2017-02-28 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/216/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver

2017-02-28 Thread zizhong
Github user zizhong commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1457#discussion_r103575599 --- Diff: proxy/Main.cc --- @@ -460,7 +460,7 @@ proxy_signal_handler(int signo, siginfo_t *info, void *ctx) shutdown_event_system = true;

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1518 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1549/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1518 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/85/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1518 Note that this is all @timbunce 's work, I just merged his two previous commits into one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1518 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1653/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/215/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1459: Mysterious uptick in user_agent SSL errors moving...

2017-02-28 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/issues/1459 Yes, this is still an issue. I need to do some more testing on PR #1446. Some variant of that will need to be added to 7.1. --- If your project is set up for it, you can reply to this e

[GitHub] trafficserver issue #1511: heap-use-after-free: Access ua_session after Http...

2017-02-28 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1511 Looks reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1518: Ensure 'service trafficserver stop’ is s...

2017-02-28 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1518 Ensure 'service trafficserver stop’ is synchronous under load on redhat Currently the service trafficserver stop command on redhat might return before ATS has exited. This is not good as

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1517 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/214/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1548/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1652/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/213/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/84/ for details. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/83/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/212/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1651/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1299 @SolidWallOfCode please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/211/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1546/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1517 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/82/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1514 Not sure if it'll let you push again on this PR, but if not, just make a new one. The point is, we don't want broken / non-functional commits in the history, so I reverted this. --- If your p

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/210/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1517 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1650/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1517 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1545/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1514 Dang it my bad... I'm gonna revert these for now. @timbunce can you please squash the commits into one commit, and push again? --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1512: Don't push stack variables in lightuserdat...

2017-02-28 Thread postwait
Github user postwait closed the pull request at: https://github.com/apache/trafficserver/pull/1512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request #1514: Ensure 'service trafficserver stop’ is s...

2017-02-28 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/81/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1544/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1649/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/80/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1516 I would like to do the review on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1543/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1648/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/79/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver pull request #1517: Remove BisonHeaderToC++.sed

2017-02-28 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1517 Remove BisonHeaderToC++.sed We can do without it, and less is more? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver b

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/209/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1542/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1647/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/78/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1646/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/208/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1516 I'm on the fence about including the `Cache-Control: private` changes in this patch. On one hand, it makes sense for that to be in this refactor. On the other, it has nothing to do with `immut

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/77/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1541/ for details. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1514 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/1516 Implement Cache-Control: immutable handling This patch makes `combo_handler` correctly handle the presence of one or more immutable flags. In short, the combo response will be immut

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1645/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1512 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1540/ for details. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/76/ for details. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1644/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1539/ for details. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1643/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/207/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1514 The FreeBSD failure is because of the VM being unstable (bloody FreeBSD needs a reboot once a week or so). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1538/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/75/ for details. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1642/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1379: Make sure to schedule connect event on correct th...

2017-02-28 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1379 @zwoop Yes, this needs to get backported. I ran into this issue testing the 7.1.x branch in production. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1514 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 I've reverted this, as per @bryancall recommendation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread timbunce
Github user timbunce commented on the issue: https://github.com/apache/trafficserver/pull/1514 Gah! killproc is written to need the -d option to follow the -p option. Sorry! ``` killproc -p $TS_PIDFILE -d 35 $TS_DAEMON ``` --- If your project is set up for it, you can rep

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 @bcall Should we back this out? Fwiw, I don't see a difference in leak detection with or without this, they both fail badly on master. --- If your project is set up for it, you can reply to th

[GitHub] trafficserver pull request #1515: Logging cache code map size fix

2017-02-28 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1515: Logging cache code map size fix

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1515 We should file an Issue on that improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1513 Set a milestone please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1514 Having some issues with this on my F25 box, e.g. ``` Stopping traffic_cop: pidof: invalid option -- 'p' Usage: pidof [options] [program [...]] Options: -s

[GitHub] trafficserver issue #1515: Logging cache code map size fix

2017-02-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1515 Can you look into fixing the APIs so this can't happen again? > On Feb 28, 2017, at 10:32 AM, Gancho Tenev wrote: > > The size of the cache code map does not correspond to th

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

2017-02-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1514 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/206/ for details. --- If your project is set up for it, you can reply to this email

  1   2   >