Re: [I] 10.0.x: OpenReadHead failed for cachekey : vector inconsistency [trafficserver]

2023-10-30 Thread via GitHub
masaori335 commented on issue #9821: URL: https://github.com/apache/trafficserver/issues/9821#issuecomment-1786448680 Let's revert the change made by #9556. I didn't noticed it breaks cache compatibility when I fixed coverity issue. I think using `uint32_t` is enough for cache and cache

Re: [I] 10.0.x: OpenReadHead failed for cachekey : vector inconsistency [trafficserver]

2023-10-30 Thread via GitHub
bneradt commented on issue #9821: URL: https://github.com/apache/trafficserver/issues/9821#issuecomment-1786348851 I'm not sure what the right direction is here. Thinking about @masaori335 's change further, it is reasonable to avoid downcasting the time_t to uint32_t. Maybe we should just

Re: [I] 10.0.x: OpenReadHead failed for cachekey : vector inconsistency [trafficserver]

2023-10-30 Thread via GitHub
bneradt commented on issue #9821: URL: https://github.com/apache/trafficserver/issues/9821#issuecomment-1786342935 The type change from uint32_t to time_t changes the type size from 32 bits to 64 bits on 64 bit systems. It makes sense that would change the stored doc structure. -- This

Re: [I] 10.0.x: OpenReadHead failed for cachekey : vector inconsistency [trafficserver]

2023-10-30 Thread via GitHub
bneradt commented on issue #9821: URL: https://github.com/apache/trafficserver/issues/9821#issuecomment-1786329946 > @masaori335 : I wonder whether the issue comes from swapping the order of pinned element here:

Re: [I] 10.0.x: OpenReadHead failed for cachekey : vector inconsistency [trafficserver]

2023-10-30 Thread via GitHub
bneradt commented on issue #9821: URL: https://github.com/apache/trafficserver/issues/9821#issuecomment-1786313138 @masaori335 : I wonder whether the issue comes from swapping the order of pinned element here:

Re: [I] 10.0.x: OpenReadHead failed for cachekey : vector inconsistency [trafficserver]

2023-10-30 Thread via GitHub
bneradt commented on issue #9821: URL: https://github.com/apache/trafficserver/issues/9821#issuecomment-1786309355 Bisecting commits on our prod system, I found the commit that introduces this vector inconsistency behavior: #9556 -- This is an automated message from the Apache Git

Re: [I] cmake: Support Layouts to configure install paths [trafficserver]

2023-10-30 Thread via GitHub
cmcfarlen closed issue #10271: cmake: Support Layouts to configure install paths URL: https://github.com/apache/trafficserver/issues/10271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] ENABLE_FIPS [trafficserver]

2023-10-30 Thread via GitHub
cmcfarlen closed issue #10678: ENABLE_FIPS URL: https://github.com/apache/trafficserver/issues/10678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] ☂ cmake: audit tasks [trafficserver]

2023-10-30 Thread via GitHub
cmcfarlen commented on issue #10241: URL: https://github.com/apache/trafficserver/issues/10241#issuecomment-1785584227 One way I have found to find the differences is to enable cmake's `CMAKE_EXPORT_COMPILE_COMMANDS` option and then compare that to the filesystem. Cmake will output a

Re: [I] ☂ cmake: audit tasks [trafficserver]

2023-10-30 Thread via GitHub
ywkaras commented on issue #10241: URL: https://github.com/apache/trafficserver/issues/10241#issuecomment-1785352426 It looks like there may be over 100 c/cpp/cc file that appear in a Makefile.am or Makefile.inc file, but not in a CMakeLists.txt file. I will work on addressing this. --

Re: [I] Issue on building ATS with quic support [trafficserver]

2023-10-30 Thread via GitHub
brbzull0 commented on issue #10660: URL: https://github.com/apache/trafficserver/issues/10660#issuecomment-1784928546 Hi @Karthikdasari0423, Bryan updated the docs so you can build ats+quiche using cmake, please have a