JosiahWI opened a new issue, #11449:
URL: https://github.com/apache/trafficserver/issues/11449
This issue was detected by valgrind.
This is the relevant part of the code, with comments added to show where
things go wrong.
```cpp
void
RecHttpLoadIpAddrsFromConfVar(const char *value_name, swoc::IPRangeSet
&addrs)
{
// We declare a fixed-size buffer to load the config content into. Good so
far.
char value[1024];
// We load the config content into the buffer. It may not fill the whole
buffer, but we don't know the
// actual content list. The unused part of the buffer is uninitialized.
if (REC_ERR_OKAY == RecGetRecordString(value_name, value, sizeof(value))) {
Debug("config", "RecHttpLoadIpAddrsFromConfVar: parsing the name [%s]
and value [%s]", value_name, value);
// We load the value into a swoc::TextView. This TextView constructor
uses the array length as the buffer size...
// fortunately, because RecGetRecordString will not null-terminate the
buffer if the content doesn't fit in it.
// Unfortunately, we don't really mean to use the whole buffer.
swoc::TextView text(value);
while (text) {
auto token = text.take_prefix_at(',');
// Now we start parsing for IPs... if the config content is empty we
still parse the entire buffer. If it were to
// hypothetically contain a leftover IP address range somehow it would
likely load it.
if (swoc::IPRange r; r.load(token)) {
Debug("config", "RecHttpLoadIpAddrsFromConfVar: marking the value
[%.*s]", int(token.size()), token.data());
addrs.mark(r);
}
}
}
Debug("config", "RecHttpLoadIpMap: parsed %zu IpMap entries",
addrs.count());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
