[jira] [Commented] (TS-1162) UnixNetVConnection.cc assertion when accepting a TLS connection

2012-03-28 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240441#comment-13240441 ] Alan M. Carroll commented on TS-1162: - Interesting. Looks reasonably. Unfortunately the s

[jira] [Commented] (TS-1138) IpMap::fill does not handle singleton, then range correctly.

2012-03-14 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229751#comment-13229751 ] Alan M. Carroll commented on TS-1138: - Fixed error where calls to tweak a range by one di

[jira] [Commented] (TS-1120) Use ink_zero / ats_zero instead of calling memset when zeroing a variable or member.

2012-02-26 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216805#comment-13216805 ] Alan M. Carroll commented on TS-1120: - Examples: @code foo bar; // value.

[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept with inbound transparency

2012-02-07 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202477#comment-13202477 ] Alan M. Carroll commented on TS-961: That's a very interesting idea. Give it a whirl and s

[jira] [Commented] (TS-1094) TS hangs after repeated requests from the same kept-alive connection

2012-02-01 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198098#comment-13198098 ] Alan M. Carroll commented on TS-1094: - Yes. Some checks need to be done that depend on da

[jira] [Commented] (TS-1094) TS hangs after repeated requests from the same kept-alive connection

2012-02-01 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197964#comment-13197964 ] Alan M. Carroll commented on TS-1094: - I have attached an alternative patch, which on my

[jira] [Commented] (TS-1094) TS hangs after repeated requests from the same kept-alive connection

2012-01-31 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197371#comment-13197371 ] Alan M. Carroll commented on TS-1094: - In theory that fix should potentially cause duplic

[jira] [Commented] (TS-548) What is Initialize.cc /.h ??

2012-01-28 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195582#comment-13195582 ] Alan M. Carroll commented on TS-548: It's used by the stand alone build and duplicates muc

[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept with inbound transparency

2012-01-27 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195201#comment-13195201 ] Alan M. Carroll commented on TS-961: I need to look at this again for 3.1.3. The TS-1077 c

[jira] [Commented] (TS-295) Allowing HTTP CONNECT to be used on non-SSL ports

2012-01-24 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192805#comment-13192805 ] Alan M. Carroll commented on TS-295: This should be re-examined after TS-1077 is committed

[jira] [Commented] (TS-1017) Upgrade LogHost / LogSock to IPv6.

2012-01-24 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192801#comment-13192801 ] Alan M. Carroll commented on TS-1017: - I have this almost entirely coded, primarily need

[jira] [Commented] (TS-1077) HTTP ports cannot be configured for IPv6 and transparency.

2012-01-21 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190595#comment-13190595 ] Alan M. Carroll commented on TS-1077: - I have been stuck for a week on the same bug which

[jira] [Commented] (TS-1077) HTTP ports cannot be configured for IPv6 and transparency.

2012-01-11 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184364#comment-13184364 ] Alan M. Carroll commented on TS-1077: - New style: Provide a single string value in recor

[jira] [Commented] (TS-857) Crash Report: HttpTunnel::chain_abort_all -> HttpServerSession::do_io_close -> UnixNetVConnection::do_io_close

2011-12-09 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166513#comment-13166513 ] Alan M. Carroll commented on TS-857: Where would it record the pending event? The presumpt

[jira] [Commented] (TS-1037) Machine.cc doesn't recognize IPs properly

2011-12-05 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162910#comment-13162910 ] Alan M. Carroll commented on TS-1037: - No, just a dumb coding error. General addresses ar

[jira] [Commented] (TS-1031) reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions

2011-11-29 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159343#comment-13159343 ] Alan M. Carroll commented on TS-1031: - This is something of a hack. Longer term what wou

[jira] [Commented] (TS-998) Broken ClientReq in TSAPI

2011-11-15 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150748#comment-13150748 ] Alan M. Carroll commented on TS-998: This is a side effect of forward transparency. The or

[jira] [Commented] (TS-1022) LogEntryHeader is a serialized structure but uses vague types.

2011-11-14 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150054#comment-13150054 ] Alan M. Carroll commented on TS-1022: - LogBufferHeader in the same file is an even worse

[jira] [Commented] (TS-857) Crash Report: HttpTunnel::chain_abort_all -> HttpServerSession::do_io_close -> UnixNetVConnection::do_io_close

2011-11-11 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148887#comment-13148887 ] Alan M. Carroll commented on TS-857: I have reviewed the patch and it looks basically corr

[jira] [Commented] (TS-1016) Make the update intervals in RecProcess run-time configurable.

2011-11-11 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148563#comment-13148563 ] Alan M. Carroll commented on TS-1016: - Looks fine, although I strongly recommend changing

[jira] [Commented] (TS-984) LogFile::roll crash at Machine::instance

2011-11-02 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142565#comment-13142565 ] Alan M. Carroll commented on TS-984: Problem identified and fixed. > LogF

[jira] [Commented] (TS-984) LogFile::roll crash at Machine::instance

2011-10-31 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140665#comment-13140665 ] Alan M. Carroll commented on TS-984: After testing by submitter and no reports of problems

[jira] [Commented] (TS-995) Change IPv6 support function names to be clearer and more compliant.

2011-10-21 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132789#comment-13132789 ] Alan M. Carroll commented on TS-995: After all of this, put back the "eq" and "cmp" to als

[jira] [Commented] (TS-986) ts/experimental has a dependency on netinet/net.h (for struct in_addr)

2011-10-20 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131875#comment-13131875 ] Alan M. Carroll commented on TS-986: It should be a sockaddr*, not in_addr. Also, if we wa

[jira] [Commented] (TS-947) AIO Race condition on non NT systems

2011-10-20 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131804#comment-13131804 ] Alan M. Carroll commented on TS-947: [Mailing list discussion|http://mail-archives.apache

[jira] [Commented] (TS-947) AIO Race condition on non NT systems

2011-10-20 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131692#comment-13131692 ] Alan M. Carroll commented on TS-947: The timed wait fix was put on trunk, which ameliorate

[jira] [Commented] (TS-963) ip_allow.config parsing bug

2011-10-13 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126867#comment-13126867 ] Alan M. Carroll commented on TS-963: The actual documentation doesn't specify anything abo

[jira] [Commented] (TS-938) Our outgoing (request) Via: header seems to always default to 127.0.0.1 as the IP identifier

2011-10-10 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124632#comment-13124632 ] Alan M. Carroll commented on TS-938: For the fix, the address used is (in order of prefere

[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept with inbound transparency

2011-10-06 Thread Alan M. Carroll (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122230#comment-13122230 ] Alan M. Carroll commented on TS-961: I don't like just appending the transparency argument