[GitHub] trafficserver issue #588: TS-4291 Adds log field "pqnhl" which ignores inter...

2016-12-16 Thread ogoodman
Github user ogoodman commented on the issue: https://github.com/apache/trafficserver/pull/588 Hi Bryan, Sorry, I probably should have let you know sooner. Please feel free to close any pull requests of mine. I have changed jobs and no longer work with Traffic

[GitHub] trafficserver issue #824: TS-4699: Adds a C++ API WebSocket example

2016-09-26 Thread ogoodman
Github user ogoodman commented on the issue: https://github.com/apache/trafficserver/pull/824 Ok, this time I had a look at the source for the relevant header files of each distribution. It seems you can't trust randomly posted, heavily upvoted gists claiming to do useful things. Who

[GitHub] trafficserver issue #824: TS-4699: Adds a C++ API WebSocket example

2016-08-20 Thread ogoodman
Github user ogoodman commented on the issue: https://github.com/apache/trafficserver/pull/824 Done (API changes consolidated). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #822: TS-4698: Adds an API call to identify WebSo...

2016-08-20 Thread ogoodman
Github user ogoodman commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/822#discussion_r75576511 --- Diff: proxy/InkAPI.cc --- @@ -4982,6 +4982,15 @@ TSHttpTxnInfoIntGet(TSHttpTxn txnp, TSHttpTxnInfoKey key, TSMgmtInt *value) return

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-30 Thread ogoodman
Github user ogoodman commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72896959 --- Diff: lib/atscppapi/examples/Makefile.am --- @@ -15,6 +15,8 @@ # See the License for the specific language governing permissions

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-29 Thread ogoodman
Github user ogoodman commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72746541 --- Diff: lib/atscppapi/examples/Makefile.am --- @@ -15,6 +15,8 @@ # See the License for the specific language governing permissions

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-24 Thread ogoodman
GitHub user ogoodman opened a pull request: https://github.com/apache/trafficserver/pull/824 TS-4699: Adds a C++ API WebSocket example Implements a simple WebSocket echo server as a C++ API InterceptPlugin. You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request #822: TS-4698: Adds an API call to identify WebSo...

2016-07-23 Thread ogoodman
GitHub user ogoodman opened a pull request: https://github.com/apache/trafficserver/pull/822 TS-4698: Adds an API call to identify WebSocket requests. This makes it possible for plugins to detect incoming WebSocket connections and thereby provide WebSocket termination if desired

[GitHub] trafficserver pull request #624: C++ API WebSocket example

2016-07-23 Thread ogoodman
Github user ogoodman closed the pull request at: https://github.com/apache/trafficserver/pull/624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #624: C++ API WebSocket example

2016-07-23 Thread ogoodman
Github user ogoodman commented on the issue: https://github.com/apache/trafficserver/pull/624 I'm going to close this particular PR now as it has become messy, doesn't reference any JIRA issue, and needs to be split into a PR on the TS API followed by one which adds the example