[GitHub] trafficserver pull request #1621: Clean up globalregisterplugin

2017-03-30 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1621 Clean up globalregisterplugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver regglobalPlugin

[GitHub] trafficserver pull request #1618: Coverity1373100:Uninitialized member

2017-03-29 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1618 Coverity1373100:Uninitialized member You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver coverity

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

2017-03-27 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1547 @zwoop this does not cherry-pick cleanly because #1446 is not backported .. #1610 backports both to 7.1.x --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1610: 7.1.x

2017-03-27 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1610 7.1.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver 7.1.x Alternatively you can review and apply these

[GitHub] trafficserver pull request #1606: require sphinx version 1.5.1

2017-03-24 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1606#discussion_r107993671 --- Diff: doc/checkvers.py --- @@ -28,9 +28,9 @@ # Check whether we have a recent version of sphinx. EPEL and CentOS are completely crazy

[GitHub] trafficserver pull request #1606: require sphinx version 1.5.1

2017-03-24 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1606 require sphinx version 1.5.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver sphinxReq Alternatively you

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-21 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r107213055 --- Diff: iocore/net/SSLNetVConnection.cc --- @@ -1338,9 +1338,8 @@ SSLNetVConnection::sslClientHandShakeEvent(int &err) }

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-20 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r106951005 --- Diff: proxy/InkAPI.cc --- @@ -9112,6 +9113,66 @@ TSSslContextDestroy(TSSslContext ctx) SSLReleaseContext(reinterpret_cast(ctx

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-20 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r106927789 --- Diff: iocore/net/P_SSLNetVConnection.h --- @@ -295,7 +302,7 @@ class SSLNetVConnection : public UnixNetVConnection

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-18 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r106796948 --- Diff: proxy/http/HttpProxyServerMain.cc --- @@ -214,7 +215,7 @@ MakeHttpProxyAcceptor(HttpProxyAcceptor &acceptor, HttpProxyPort &

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-18 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r106796868 --- Diff: proxy/InkAPI.cc --- @@ -9112,6 +9113,66 @@ TSSslContextDestroy(TSSslContext ctx) SSLReleaseContext(reinterpret_cast(ctx

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-17 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1594 Early intervention APIs This PR contains: -> APIs for early intervention -> docs -> example plugin to show the usage You can merge this pull request into a Git repo

[GitHub] trafficserver pull request #1586: Update the list of overridable configs

2017-03-15 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1586 Update the list of overridable configs "proxy.config.ssl.client.cert.path" and "proxy.config.ssl.client.cert.filename" added to the list You can merge this pul

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

2017-03-15 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1547 +1 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #1503: client cert should be added to netvcoptions only ...

2017-03-14 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1503 7.1.x has good amount of works on client certs, so yes this should go in 7.1.x too :) . Like I said, it is unnecessary to check for client cert in the remap function when the cert is only

[GitHub] trafficserver issue #1579: Clean up h2client.py to be a general testing tool

2017-03-14 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/issues/1579 I am working (read "hacking hyper") on the h2 module of Traffic-Replay. Once that gets open sourced, we will have a better h2 client. The current h2client is meant just fo

[GitHub] trafficserver pull request #1576: Add option to choose interface

2017-03-13 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1576 Add option to choose interface You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver microserver Alternatively

[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

2017-03-01 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1299#discussion_r103736131 --- Diff: proxy/http/HttpTransact.cc --- @@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s) ink_assert(s

[GitHub] trafficserver issue #1503: client cert should be added to netvcoptions only ...

2017-03-01 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1503 It should be merged with master, as well as backported to 7.1.x. Client cert is being checked every time a remap is performed rather it should be checked before making an actual ssl

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-03-01 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1446 Looks good to me.. I tested with a plugin that requires this hook --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-28 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1299 @SolidWallOfCode please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1508: Fix template directory path

2017-02-27 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1508 This fixes ba420782340dc2fa38e955d3b6645fa1263df0ea in #1468 . #1468 was causing master not to load the template table due to wrong config path --- If your project is set up for it, you

[GitHub] trafficserver pull request #1508: Fix template directory path

2017-02-27 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1508 Fix template directory path You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver erropage Alternatively you can

[GitHub] trafficserver pull request #1503: client cert should be added to netvcoption...

2017-02-27 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1503 client cert should be added to netvcoptions only when needed backport to 7.1.x You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

2017-02-22 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1465 Shouldn't the documentation be a inside the doc folder of ATS? Will this show up on the traffic server website? --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-02-09 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1299 hmm, we need to remove the usage of varargs from all subsequent methods if we pass the internal message buffer. Looking at the code and the fail output of regression test, we can not pass

[GitHub] trafficserver pull request #1432: npn string should be updated on unregister...

2017-02-09 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1432 npn string should be updated on unregistering a protocol as well You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz

[GitHub] trafficserver issue #1396: check if any of client cert path or file is null

2017-01-30 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1396 please review @zwoop @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request #1396: check if any of client cert path or file i...

2017-01-30 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1396 check if any of client cert path or file is null fix for client cert loading problem You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-01-30 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1357 @SolidWallOfCode, @shinrich Please review. In summary, * proxy.config.ssl.client.cert.path has been completely removed. * proxy.config.ssl.client.cert.filename has been

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-01-25 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1357 I was thinking to have one overridable config for the client cert containing the partial or absolute path to avoid the memory allocation in Layout, but that will break the convention of

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-01-23 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1357 please review @SolidWallOfCode This will reduce the unnecessary allocations. This checks if the client cert filename and path under txn_cnf has the same value as the global defaults

[GitHub] trafficserver pull request #1357: TS-5022: reduce memory allocation in clien...

2017-01-23 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1357 TS-5022: reduce memory allocation in clientcert lookup You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS

[GitHub] trafficserver pull request #1356: Ts 5022

2017-01-23 Thread persiaAziz
Github user persiaAziz closed the pull request at: https://github.com/apache/trafficserver/pull/1356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1356: Ts 5022

2017-01-23 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1356 Ts 5022 You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS-5022 Alternatively you can review and apply

[GitHub] trafficserver issue #1341: openssl errors for every request

2017-01-19 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/issues/1341 PR: https://github.com/apache/trafficserver/pull/1347/files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1347: TS-5022: nullptr check

2017-01-19 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1347 TS-5022: nullptr check You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS-5022 Alternatively you can

[GitHub] trafficserver issue #1346: relative_to(char* path, char* filename) should re...

2017-01-19 Thread persiaAziz
GitHub user persiaAziz opened an issue: https://github.com/apache/trafficserver/issues/1346 relative_to(char* path, char* filename) should return null if path is null Digging down the code, ink_filepath_merge(char *path, int pathsz, const char *rootpath, const char *addpath, int

[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...

2017-01-13 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/issues/1323 PR: https://github.com/apache/trafficserver/pull/1325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset

2017-01-12 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1324 yah no need to merge this since the actual problem is somewhere else. I just didn't want to master to be unstable, that is why I made this --- If your project is set up for it, yo

[GitHub] trafficserver pull request #1324: issue-1323: fix RecDataset

2017-01-12 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1324 issue-1323: fix RecDataset set nullptr if a config specified to be NULL in records.config You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...

2017-01-12 Thread persiaAziz
GitHub user persiaAziz opened an issue: https://github.com/apache/trafficserver/issues/1323 NULL in records.config being interpreted as a string CONFIG proxy.config.ssl.client.cert.path STRING NULL CONFIG proxy.config.ssl.client.cert.filename STRING NULL The two configs

[GitHub] trafficserver pull request #1316: TS-5022: remove goto in SSLConfig : getnew...

2017-01-09 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1316 TS-5022: remove goto in SSLConfig : getnewCTX You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS-5022

[GitHub] trafficserver pull request #1315: TS-5022: fix silent exit problem

2017-01-09 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1315 TS-5022: fix silent exit problem You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS-5022 Alternatively you

[GitHub] trafficserver issue #1308: CID 1368316 & 1368315: Leaks and NULL references

2017-01-08 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/issues/1308 https://github.com/apache/trafficserver/pull/1310 should fix CID 1368316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #1310: TS-5022: resource leak fix CID 1368316

2017-01-08 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1310 TS-5022: resource leak fix CID 1368316 You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS-5022

[GitHub] trafficserver issue #1305: CID 1368316 Resource leak

2017-01-07 Thread persiaAziz
GitHub user persiaAziz opened an issue: https://github.com/apache/trafficserver/issues/1305 CID 1368316 Resource leak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1226: TS-5022: Allow multiple client cert for ATS

2017-01-05 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1226 Please review @shinrich. The client context initialization and creation parts have been moved to SSLConfig --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1226: TS-5022: Allow multiple client cert for AT...

2017-01-05 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1226#discussion_r94828732 --- Diff: proxy/http/HttpSM.cc --- @@ -4059,6 +4061,16 @@ HttpSM::do_remap_request(bool run_inline) pending_action = remap_action_handle

[GitHub] trafficserver pull request #1226: TS-5022: Allow multiple client cert for AT...

2017-01-05 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1226#discussion_r94827614 --- Diff: iocore/net/SSLNetProcessor.cc --- @@ -76,6 +77,7 @@ SSLNetProcessor::start(int, size_t stacksize) SSLError("Can't init

[GitHub] trafficserver pull request #1226: TS-5022: Allow multiple client cert for AT...

2017-01-05 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1226#discussion_r94827291 --- Diff: iocore/net/SSLNetProcessor.cc --- @@ -67,7 +67,8 @@ SSLNetProcessor::start(int, size_t stacksize) // Acquire a

[GitHub] trafficserver issue #1226: TS-5022: Allow multiple client cert for ATS

2017-01-05 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1226 Please review @shinrich . The map containing client ctxs have been moved to sslconfig --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1226: TS-5022: Allow multiple client cert for ATS

2017-01-04 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1226 @shinrich Lock problem has been fixed. Please review again. Checking for nullptr is unnecessary since we are allowing nullptr to be key. --- If your project is set up for it, you can

[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

2017-01-03 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1299 TS-2888: remove vararg and format parameters from build_error_resoponse This removes vararg and the formatting parameter from build_error_response. However the underlying

[GitHub] trafficserver issue #1226: TS-5022: Allow multiple client cert for ATS

2016-12-20 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1226 Please review @shinrich --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1269: TS-5094: URL encoding in redirect pages

2016-12-19 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1269 TS-5094: URL encoding in redirect pages You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS-5094

[GitHub] trafficserver issue #1226: TS-5022: Allow multiple client cert for ATS

2016-11-18 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1226 Please review @shinrich @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request #1226: TS-5022: Allow multiple client cert for AT...

2016-11-17 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1226 TS-5022: Allow multiple client cert for ATS Allow ATS to choose the certificate to use while making ssl connection with an origin server. Remap plugin can set

[GitHub] trafficserver pull request #1212: TS-1257: [ssl_cipher_table] replace TCL Ha...

2016-11-08 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1212 TS-1257: [ssl_cipher_table] replace TCL HashTable by unordered_map Replace the underlying TCL hash table implementation of ssl_cipher_name_table by STL unordered_map. This PR partially

[GitHub] trafficserver pull request #1197: TS-1257: replace TCL_HashTable with unorde...

2016-11-08 Thread persiaAziz
Github user persiaAziz closed the pull request at: https://github.com/apache/trafficserver/pull/1197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1197: TS-1257_ssl_cipher_name_table: replace TCL_HashTa...

2016-11-06 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1197 TCL hash is being used in numerous places including RecCore, InkAPI, URLRewrite etc. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1197: TS-1257_ssl_cipher_name_table: replace TCL_HashTa...

2016-11-04 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1197 Please review @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1197: TS-1257_ssl_cipher_name_table: replace TCL_HashTa...

2016-11-04 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1197 Please review @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1197: TS-1257_ssl_cipher_name_table: replace TCL...

2016-11-04 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1197 TS-1257_ssl_cipher_name_table: replace TCL_HashTable with unordered_map Replacement of InkHashTable with unordered_map. This PR partially addresses TS-1257. I plan to gradually replace

[GitHub] trafficserver issue #1120: TS-4978: illegal memory access with ticket_key.fi...

2016-10-31 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1120 The conflict is resolved. Please check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1120: TS-4978: illegal memory access with ticket_key.fi...

2016-10-31 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1120 I will do a local merge and then make a new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #1120: TS-4978: illegal memory access with ticket_key.fi...

2016-10-18 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1120 Please review @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1120: TS-4978: illegal memory access with ticket...

2016-10-18 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1120#discussion_r83942590 --- Diff: iocore/net/SSLConfig.cc --- @@ -253,8 +253,8 @@ SSLConfigParams::initialize() ats_free(CACertRelativePath); #if

[GitHub] trafficserver pull request #1120: TS-4978: illegal memory access with ticket...

2016-10-18 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1120 TS-4978: illegal memory access with ticket_key.filename Avoiding illegal memory access by checking the return value of readConfigStringAlloc . You can merge this pull request into a

[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-17 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1024 Please review @shinrich --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1024: TS-4858: fix memory leak of global_default...

2016-10-05 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1024#discussion_r82054996 --- Diff: iocore/net/SSLCertLookup.cc --- @@ -160,7 +160,40 @@ ticket_block_alloc(unsigned count) return ptr

[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-05 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1024 Please review @shinrich --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1045: TS-4891: Initializing prefix_str on declaration

2016-09-27 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1045 Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver pull request #1045: TS-4891: Initializing prefix_str on declar...

2016-09-27 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1045#discussion_r80701553 --- Diff: proxy/Main.cc --- @@ -1507,9 +1507,8 @@ main(int /* argc ATS_UNUSED */, const char **argv) // re-start it again, TS will crash

[GitHub] trafficserver issue #1045: TS-4891: Initializing prefix_str on declaration

2016-09-26 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1045 Ahh. I didn't know about "make test", that is why I wasn't seeing these errors. Please approve again. The build should pass this time. --- If your project is se

[GitHub] trafficserver issue #1045: TS-4891: Initializing prefix_str on declaration

2016-09-26 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1045 Please approve again. The previous jenkins build failed because of wrong function call in Diags.i . I don't know why my compiler didn't complain about that --- If your project

[GitHub] trafficserver issue #1045: TS-4891: Initializing prefix_str on declaration

2016-09-26 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1045 Please review the changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1045: TS-4891: Initializing prefix_str on declar...

2016-09-23 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1045 TS-4891: Initializing prefix_str on declaration prefix_str should be initialized before setup_diagslog() is called in Diags.cc:146 since a failure in setup_diagslog can lead to a call of

[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-09-15 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1024 pointer check removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1024: TS-4858: fix memory leak of global_default...

2016-09-15 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1024 TS-4858: fix memory leak of global_default_keyblock fix memory leak of global_default_keyblock. global_defualt_keyblock will be freed and reassigned on each reload You can merge

[GitHub] trafficserver pull request #1008: TS-4263: keyblock variable configurable vi...

2016-09-12 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1008#discussion_r78409343 --- Diff: iocore/net/SSLUtils.cc --- @@ -2055,9 +2055,11 @@ SSLParseCertificateConfiguration(const SSLConfigParams *params, SSLCertLookup *l

[GitHub] trafficserver pull request #1008: TS-4263: keyblock variable configurable vi...

2016-09-12 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1008#discussion_r78407691 --- Diff: iocore/net/SSLUtils.cc --- @@ -2055,9 +2055,11 @@ SSLParseCertificateConfiguration(const SSLConfigParams *params, SSLCertLookup *l

[GitHub] trafficserver pull request #1008: TS-4263: keyblock variable configurable vi...

2016-09-12 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1008#discussion_r78406447 --- Diff: iocore/net/SSLUtils.cc --- @@ -2055,9 +2055,12 @@ SSLParseCertificateConfiguration(const SSLConfigParams *params, SSLCertLookup *l

[GitHub] trafficserver pull request #1008: TS-4263: keyblock variable configurable vi...

2016-09-12 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1008 TS-4263: keyblock variable configurable via records.config Default value proxy.config.ssl.server.ticket_key.filename is set to NULL * If the ticket_key_filename is not set by the user

[GitHub] trafficserver pull request #991: TS-4503: Remove the class ErrorClass and al...

2016-09-09 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/991#discussion_r78242362 --- Diff: proxy/Main.cc --- @@ -908,7 +908,7 @@ check_fd_limit() if (fds_throttle > fds_limit + THROTTLE_FD_HEADROOM) {

[GitHub] trafficserver pull request #991: TS-4503: Remove the class ErrorClass and al...

2016-09-09 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/991#discussion_r78242010 --- Diff: proxy/logging/LogBuffer.h --- @@ -25,6 +25,7 @@ #define LOG_BUFFER_H #include "ts/ink_platform.h" +#i

[GitHub] trafficserver pull request #991: TS-4503: Remove the class ErrorClass and al...

2016-09-09 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/991#discussion_r78228327 --- Diff: proxy/logging/LogBuffer.h --- @@ -25,6 +25,7 @@ #define LOG_BUFFER_H #include "ts/ink_platform.h" +#i

[GitHub] trafficserver pull request #991: TS-4503: Remove the class ErrorClass and al...

2016-09-08 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/991#discussion_r78103190 --- Diff: proxy/Main.cc --- @@ -908,7 +908,7 @@ check_fd_limit() if (fds_throttle > fds_limit + THROTTLE_FD_HEADROOM) {

[GitHub] trafficserver pull request #991: TS-4503: Remove the class ErrorClass and al...

2016-09-08 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/991 TS-4503: Remove the class ErrorClass and all it's child classes TS-4503: Remove the class ErrorClass and all it's child classes …(for e.g., machinFatal, processFatal...)

[GitHub] trafficserver issue #942: TS 4263: Global key block configurable via Records...

2016-09-06 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/942 If the ticket key file has a keyblock which is less than 48 bytes, then the assertion statement in ssl_callback_session_ticket(..) will fail. This is the current logic. One thing that

[GitHub] trafficserver pull request #942: TS 4263: Global key block configurable via ...

2016-08-30 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/942#discussion_r76885786 --- Diff: iocore/net/SSLUtils.cc --- @@ -2018,11 +2047,17 @@ SSLParseCertificateConfiguration(const SSLConfigParams *params, SSLCertLookup *l

[GitHub] trafficserver pull request #942: TS 4263: Global key block configurable via ...

2016-08-30 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/942 TS 4263: Global key block configurable via Records.config You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS

[GitHub] trafficserver pull request #938: TS-4263: Global key block configurable via ...

2016-08-30 Thread persiaAziz
Github user persiaAziz closed the pull request at: https://github.com/apache/trafficserver/pull/938 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #938: TS-4263: Global key block configurable via Records...

2016-08-30 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/938 Closing this PR since I messed up my branch with git [AGAIN!] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #938: TS-4263: Global key block configurable via ...

2016-08-30 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/938#discussion_r76832926 --- Diff: iocore/net/SSLUtils.cc --- @@ -95,6 +95,8 @@ struct ssl_user_config { ssl_user_config() : opt(SSLCertContext::OPT_NONE

[GitHub] trafficserver pull request #938: TS-4263: Global key block configurable via ...

2016-08-30 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/938#discussion_r76831604 --- Diff: iocore/net/SSLUtils.cc --- @@ -544,7 +547,64 @@ ssl_context_enable_ecdh(SSL_CTX *ctx) return ctx; } +static

[GitHub] trafficserver issue #938: TS-4263: Global key block configurable via Records...

2016-08-30 Thread persiaAziz
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/938 Thanks @zwoop . I was using a tool for clang-formatting. Please approve --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver pull request #938: TS-4263: Global key block configurable via ...

2016-08-29 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/938 TS-4263: Global key block configurable via Records.config You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver TS

[GitHub] trafficserver pull request #932: TS-4263: Global key block configurable via ...

2016-08-26 Thread persiaAziz
Github user persiaAziz closed the pull request at: https://github.com/apache/trafficserver/pull/932 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #932: TS-4263: Global key block configurable via ...

2016-08-26 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/932 TS-4263: Global key block configurable via Records.config Global key block configurable via Records.config You can merge this pull request into a Git repository by running: $ git

  1   2   >