Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1248
For future references, this really should have been squashed down to one
commit before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1248
Please squash commits before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1248
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/1188/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1248
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1294/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1248
The logic looks reasonable. The invocation of the OWNER privilege looks
correct. I guess we could avoid that elevation if we did the chmod at the
point of the file was created, but I
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1248
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
