[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Not going to do the reverts here, but please be careful going forward with squashing commits that are fixes / review comments. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Well, dammit, I screwed up, this really shouldn't have been merged, you really must squash multiple commits like this into one commit (now I landed one commit that is not correct). :-/ --- If

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1350/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1242/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1349/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread meeramn
Github user meeramn commented on the issue: https://github.com/apache/trafficserver/pull/1320 Ran clang-format and pushed the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1337/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 @meeramn Can you re-run clang-format and update the PR please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1231/ for details. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-17 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1320 Ship it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Marking this for 7.1.0, we really need this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi