[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @SolidWallOfCode Ping? Also, seems this needs to be rebased now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @SolidWallOfCode Is this going to go in for 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1357 Whilst the configuration of SSL keys and certificates is a bit unfortunate, I think that it is important to be consistent. Separately, you have to define the base directory for relativ

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1357 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1321/ for details. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1357 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1428/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1357 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1320/ for details. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1357 @SolidWallOfCode, @shinrich Please review. In summary, * proxy.config.ssl.client.cert.path has been completely removed. * proxy.config.ssl.client.cert.filename has been rename

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1357 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1427/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1357 The problem (as @persiaAziz patiently explained) is the client certificate is overridable which means it cannot be reliable precomputed when `remap.config` is parsed. In theory a plug

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1357 I was thinking to have one overridable config for the client cert containing the partial or absolute path to avoid the memory allocation in Layout, but that will break the convention of ha

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1357 I think I want a different approach on this. I'll talk with @persiaAziz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @shinrich @SolidWallOfCode Is this landing for 7.1.x? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 This has to go into 7.1.0 as well, since we already landed previous tries :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1357 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1256/ for details. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1357 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1363/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1357 please review @SolidWallOfCode This will reduce the unnecessary allocations. This checks if the client cert filename and path under txn_cnf has the same value as the global defaults. ---