Github user shenzhang920 commented on the issue:
https://github.com/apache/trafficserver/pull/1415
@maskit Thanks for the guidance, just create a new pull request in 6.2.x to
cherry-pick the one merged in master
---
If your project is set up for it, you can reply to this email and
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1415
@shenzhang920 Thank you for the new pull-request. You can just close this
pull request.
After merging the new pull request, you can open a new one for 6.2.x with
cherry-picked commit, or
Github user shenzhang920 commented on the issue:
https://github.com/apache/trafficserver/pull/1415
@maskit @zwoop Got it! I made the change on master and create another
pull request. How do I discard this pull request?
---
If your project is set up for it, you can reply to this
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1415
Oh yeah, if this is not a back port from master, then this should be
changed / closed, and replaced with a PR against master. We always commit on
master, and then suggest back ports to the RMs
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1415
@shenzhang920 This should be fixed on master too, right? If there's the
same issue on master, we should fix it on master first, and then we can
cherry-pick the commit for 6.2.x.
Could you
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1415
You can ignore the clang-analyzer build failures, since 6.2.x branch is
busted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1415
clang-analyzer build *failed*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/49/ for details.
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1415
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1485/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1415
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1378/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1415
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user shenzhang920 commented on the issue:
https://github.com/apache/trafficserver/pull/1415
@maskit I made another commit to fix the clang failure, can you trigger the
build again? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1415
clang-analyzer build *failed*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/37/ for details.
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1415
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1473/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1415
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1366/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1415
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user shenzhang920 commented on the issue:
https://github.com/apache/trafficserver/pull/1415
@maskit Right, since there're 3 caller now, I moved some of the repeated
code inside set_tcp_congestion_control()
---
If your project is set up for it, you can reply to this email and
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1415
@shenzhang920 I understand why you put the blocks there because the logic
was originally in `new_connection()`. However, I'm not a big fun of putting the
same code into two (or more) places.
17 matches
Mail list logo
