Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1522
or we can use:
```
if (vc->write.enabled && vc->write.triggered || vc->write.error &&
vc->write.vio._cont != nullptr)
```
keep old condition then add new condition.
-
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1522
to review #947 again, my suggestion is
```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
index 85d7527..5ef65cb 100644
--- a/iocore/net/UnixNet.cc
+++ b/ioc
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Still looking good on Docs, but would like to give it at least another 24
hours before we declare victory.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Testing this on docs, it's similar to #1444 which did not solve the
problems for us there (completely at least), hopefully the additions to the
read case helps.
---
If your project is set up
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Looks reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1522
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/224/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/92/ for details.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1556/ for details.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1522
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1660/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Here is a workaround for issue #1401. I ran into issues with the read also
coring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
10 matches
Mail list logo
