Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*!
https://ci.trafficserver.apache.org/job/clang-analyzer-github/296/
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*!
https://ci.trafficserver.apache.org/job/linux-github/1630/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*!
https://ci.trafficserver.apache.org/job/icc-github/164/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *successful*!
https://ci.trafficserver.apache.org/job/freebsd-github/1735/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/38/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang format *successful*!
https://ci.trafficserver.apache.org/job/clang-format-github/40/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *failed*! https://ci.trafficserver.apache.org/job/RAT-github/53/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Squashing and verifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1534
@bryancall says `StringView` should be changed to be conformant with
`string_ref` from C++17. This would involve changing the method naming scheme
and adding some additional methods
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*!
https://ci.trafficserver.apache.org/job/clang-analyzer-github/288/
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*!
https://ci.trafficserver.apache.org/job/icc-github/156/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*!
https://ci.trafficserver.apache.org/job/linux-github/1621/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *successful*!
https://ci.trafficserver.apache.org/job/freebsd-github/1726/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*!
https://ci.trafficserver.apache.org/job/RAT-github/44/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/30/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang format *successful*!
https://ci.trafficserver.apache.org/job/clang-format-github/31/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*!
https://ci.trafficserver.apache.org/job/clang-analyzer-github/283/
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*!
https://ci.trafficserver.apache.org/job/clang-analyzer-github/282/
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*!
https://ci.trafficserver.apache.org/job/linux-github/1616/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*!
https://ci.trafficserver.apache.org/job/clang-analyzer-github/280/
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *successful*!
https://ci.trafficserver.apache.org/job/freebsd-github/1721/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *successful*!
https://ci.trafficserver.apache.org/job/freebsd-github/1720/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*!
https://ci.trafficserver.apache.org/job/icc-github/151/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*!
https://ci.trafficserver.apache.org/job/clang-analyzer-github/279/
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/25/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*!
https://ci.trafficserver.apache.org/job/linux-github/1614/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*!
https://ci.trafficserver.apache.org/job/RAT-github/39/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *successful*!
https://ci.trafficserver.apache.org/job/freebsd-github/1718/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang format *successful*!
https://ci.trafficserver.apache.org/job/clang-format-github/26/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/23/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *failed*!
https://ci.trafficserver.apache.org/job/icc-github/150/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*!
https://ci.trafficserver.apache.org/job/RAT-github/38/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang format *successful*!
https://ci.trafficserver.apache.org/job/clang-format-github/25/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *failed*!
https://ci.trafficserver.apache.org/job/icc-github/148/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*!
https://ci.trafficserver.apache.org/job/icc-github/147/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *successful*!
https://ci.trafficserver.apache.org/job/freebsd-github/1717/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*!
https://ci.trafficserver.apache.org/job/RAT-github/36/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang format *successful*!
https://ci.trafficserver.apache.org/job/clang-format-github/23/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *failed*!
https://ci.trafficserver.apache.org/job/linux-github/1613/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/22/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *failed*!
https://ci.trafficserver.apache.org/job/linux-github/1612/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/21/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang format *successful*!
https://ci.trafficserver.apache.org/job/clang-format-github/22/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*!
https://ci.trafficserver.apache.org/job/RAT-github/35/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1534
I can see "h2" if I build it on Linux with gcc but not on Mac with clang.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*!
https://ci.trafficserver.apache.org/job/clang-analyzer-github/274/
---
If your project is set up for it, you can reply to this email and have your
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1534
@maskit I'll look at that, but zwoop's test output has the 'h2' in it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *successful*!
https://ci.trafficserver.apache.org/job/freebsd-github/1711/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*!
https://ci.trafficserver.apache.org/job/linux-github/1606/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*!
https://ci.trafficserver.apache.org/job/icc-github/142/
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/15/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*!
https://ci.trafficserver.apache.org/job/RAT-github/29/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang format *successful*!
https://ci.trafficserver.apache.org/job/clang-format-github/16/
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1534
It looks Http2ClientSession::PROTO_TAG is empty to me. I see two spaces
between "http/1.1" and "tls/1.2".
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/264/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1596/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/132/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *failed*! See
https://ci.trafficserver.apache.org/job/autest-github/5/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1701/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-format check *successful*! See
https://ci.trafficserver.apache.org/job/clang-format-github/6/ for details.
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*! See
https://ci.trafficserver.apache.org/job/RAT-github/19/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Gonna build it again anyways ... [approve-ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/263/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/131/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1595/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
AU check *successful*! See
https://ci.trafficserver.apache.org/job/autest-github/4/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
RAT check *successful*! See
https://ci.trafficserver.apache.org/job/RAT-github/18/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-format check *successful*! See
https://ci.trafficserver.apache.org/job/clang-format-github/5/ for details.
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD11 build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1700/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Upon further review of this, #1520, and #1506, I think this is just a bug
fix, in that there was already code in place to report the protocol stack in
the VIA header. Therefore this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/RAT-github/1/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mlibbey commented on the issue:
https://github.com/apache/trafficserver/pull/1534
I'm terrible at reading RFC docs, so, fwiw, the Via header structure is
described here:
https://tools.ietf.org/html/rfc7230#section-5.7.1
---
If your project is set up for it, you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1534
It even works:
```
odin (08:54) 283/0 $ curl -D - -o /dev/null -s https://www.ogre.com/ |
grep Via:
Via: http/1.1 tls/1.2 tcp ipv4 Cosmo (ApacheTrafficServer/7.2.0 [cRs f ])
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1534
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1534
H. I think I'd leave that for another day. Those aren't really used
internally, only to forward the API request. The return value isn't examined
except to check for `nullptr`
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1534
ð
Looks good.
Just one question. Should the internal "protocol_contains" functions return
"StringView" as well?
Obviously we should not be changing the return type of
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/232/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1564/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1668/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/100/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *failed*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/231/ for details.
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *failed*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/230/ for details.
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/99/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1667/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1563/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/98/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1562/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
clang-analyzer build *failed*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/229/ for details.
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1666/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1561/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1534
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/97/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1534
I checked the compiler output and AFAICT passing a `StringView` by value is
the same cost as passing two integers. That is, passing a `StringView` by value
has the same performance
92 matches
Mail list logo
