[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2017-01-05 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/801 I'm actually holding off on this one. We are running our version of 5.3.x with this change, but there were a number of other changes as well. Not clear this one is needed. I plan to do str

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-25 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/801 We are running with this change locally. I've made some other changes on this front too. I'll look at adding some asserts/warning messages to see whether we are still encountering this iss

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-18 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/801 Ah. The invariant is that you are not supposed to be getting IO events during session hook processing. Maybe the fact that this is happening is the root cause of the bug? This change a

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/801 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/342/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/801 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/448/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-18 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/801 I'm not sure how to interpret your comment. I was seeing IO events trailing during the SSN close handling. For example, it looks like I could call the clearing do_io_write in Http1ClientSes

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/801 I had to re-read this code to refresh my memory on how this works. I think that the invariant that the ``ProxyClientSession`` requires is that the API hooks are the first and last operations pe

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/801 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/327/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/801 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/434/ for details. --- If your project is set up for it, you can reply to this email and have your r